Closed Bug 1704024 Opened 3 years ago Closed 3 years ago

about:profiling - Radiobuttons no longer centered with strings on row

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Firefox 89
defect

Tracking

(firefox-esr78 unaffected, firefox87 unaffected, firefox88 unaffected, firefox89 verified, firefox90 verified)

VERIFIED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified
firefox90 --- verified

People

(Reporter: cfogel, Assigned: itiel_yn8)

References

(Blocks 1 open bug, Regression, )

Details

(Keywords: regression, Whiteboard: [proton-aboutpages] [priority:2c])

Attachments

(1 file)

Attached image probaseline.png

Affected versions

  • 89.0a1(2021-04-07);

Affected platforms

  • Win10, Ubuntu 18.04;
  • will check on other OSs when possible;

Steps to reproduce

  1. Launch Firefox, access about:profiling
  2. Scroll down, look at items;

Expected result

  • radiobuttons and checkboxes are centered with the row name (not description bellow)

Actual result

  • radiobuttons are not centered nicely;

Regression range

Additional notes

  • zoom in for better visibility;
  • attached screenshot to illustrate the issue.
Has Regression Range: --- → yes
Has STR: --- → yes
Regressed by: 1701448
Blocks: 1694394
Flags: needinfo?(rtestard)
Whiteboard: [proton-aboutpages]
See Also: → 1704027

https://searchfox.org/mozilla-central/rev/5a8487d8e9dd114289083800f723d9c56c9a8003/devtools/client/themes/aboutprofiling.css#56

This needs to be updated to match the new radio height (16x16), so that value should be 22px.
Ideally, CSS grid would be used and it would prevent these height update bugs from happening.

Flags: needinfo?(rtestard)
Priority: -- → P2
Whiteboard: [proton-aboutpages] → [proton-aboutpages] [priority:2b]
OS: Unspecified → All
Hardware: Unspecified → All

Set release status flags based on info from the regressing bug 1701448

Whiteboard: [proton-aboutpages] [priority:2b] → [proton-aboutpages] [priority:2c]

Fixed by bug 1704027.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Assignee: nobody → itiel_yn8
Depends on: 1704027
Target Milestone: --- → 89 Branch

Hello,

Confirming this issue as verified fixed on 90.a1(20210519083222) and 89.0b14(20210518190425) on Ubuntu 20, Win10x64 and macOS11.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: