Affected versions

• Firefox 88.0b7
• Latest Nightly 89.0a1

Affected platforms

• Windows 10
• Ubuntu 18.04
• macOS 11.3

Steps to reproduce

1. Set up browser.proton.enabled
2. Open wikipedia.org (or any webpage that has hyperlinks)
3. Right click on any hyperlink
4. Select Bookmark Link

Expected result

• Add a new bookmark menu has no graphical issues.

Actual result

• Bookmarks toolbar dropdown has no borders and the menu itself is larger then the one without proton enabled.

Regression range

• First bad: 42f6412b7bc1c6ccafe07c33e0027c6c065c3acd
• Last good: df4b939f11b763f9ab3d0a834fb921b5a5ed253f
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=df4b939f11b763f9ab3d0a834fb921b5a5ed253f&tochange=42f6412b7bc1c6ccafe07c33e0027c6c065c3acd
• Potential regressor: Bug 1697863 - Add preliminary Proton styles for browser UI menulists

Additional notes

• Screenshot with the issue was attached.
• Not sure which proton tag I should add in Whiteboard so I'll leave it to you Mike.

Suggested severity

• I would say this could be a S3 severity, it is quite visible and is a recent regression.

I'm going to add [proton-door-hangers] in Whiteboard just so it get triaged soon since this is Proton related.

If this is not reproducible with browser.proton.enabled set to false, then we don't need to worry about Firefox 88 Beta.

I suspect this problem is actually going to go away when browser.proton.modals.enabled gets set to true. Can you confirm, Bogdan?

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #2)

If this is not reproducible with browser.proton.enabled set to false, then we don't need to worry about Firefox 88 Beta.

I suspect this problem is actually going to go away when browser.proton.modals.enabled gets set to true. Can you confirm, Bogdan?

Activating proton modals do make it look different but still not the best (not aligned with Name/Tags and the description of tags is cramped between Tags and Save/Cancel buttons) . Maybe that's already tracked in another bug though.

It is - I think bug 1702293 takes care of most or all of this.

Since bug 1702293 now landed, can you please validate if this bug can now be closed?

Yes, this can be closed now. I verified that the new bookmark modal looks much better after the fix in bug 1702293.