Site permission panel is missing a number of Proton styles
Categories
(Firefox :: Site Permissions, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | verified |
People
(Reporter: obotisan, Assigned: emmamalysz)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-door-hangers])
Attachments
(3 files)
permission 1.png
Affected versions
- Firefox 89.0a1
Affected platforms
- Windows 10 x64
- Ubuntu 18.04 x64
- macOS 10.15
Precondition
The following prefs are set to true in about:config:
- browser.proton.enabled
- browser.proton.doorhangers.enabled (for preliminary testing this also required, until the work is moved to the main pref)
Steps to reproduce
- Go to https://permission.site/.
- Click on the "Location" button.
- Click on the "Allow" button.
- Click on the site permission icon.
Expected result
- There is no arrow before "Last access..."
- The "Last access..." string is smaller than the "Access your location" string.
- The Allowed/Blocked string is inside a grey rectangle.
Actual result
- There is an arrow before "Last access..."
- The "Last access..." string is too big.
- The Allowed/Blocked string is not inside a grey rectangle.
Regression range
- This is not a regression.
Additional notes
- Please look at the attached image. This is the one from the specs.
|
Reporter | |
Comment 1•3 years ago
|
||
This is how it looks at the moment
|
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Comment 3•3 years ago
|
||
Tyler, just to confirm, is this really a dupe of Bug 1703012? Permission and control panel are two distinct panels.
|
|
||
Comment 4•3 years ago
|
||
Thanks for catching that @pbz. That was a mistake on my part. I am re-opening this and marking it P1 and as blocking the graduation bug.
|
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 5•3 years ago
|
||
Going to assign myself this bug, as I think it can benefit from a few style fixes I'm planning on implementing in 1703012
|
|
Assignee | |
Comment 6•3 years ago
|
||
Changes includde padding/margin changes and button structure
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2232405d3707 update site permission panel formatting r=mconley,pbz
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 9•3 years ago
|
||
We verified the fix using latest Nightly 89.0a1 on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64. The bug is not reproducing anymore.
Description
•