[Proton] Move Take Screenshot label above "Search [search engine] for ..." item in the selection context menu
Categories
(Firefox :: Menus, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox87 | --- | unaffected |
| firefox88 | --- | wontfix |
| firefox89 | --- | verified |
People
(Reporter: bmaris, Assigned: masterwayz)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-context-menus] [priority:2c])
Attachments
(2 files)
Image showing the proposed and actual
| Comment hidden (obsolete) |
|
Reporter | |
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
Meridel, could you clarify what you'd like us to do? Because in the "context menu on a page" (slides 80 / 81) on https://docs.google.com/presentation/d/1Ufd0A3HsziyXXAjXYNH84P2bu7RdTxARsA0xpKmwIWs/edit?ts=606c5bdf#slide=id.gb7754f26c5_10_64 , there are separators around "take a screenshot", and a separator between it and "select all". From an engineering perspective, I assumed that this meant there should always be separators around it. It seems a little bit strange to have the separator between select all and take a screenshot for the page context menu, but to get rid of it when something is selected? Maybe I'm missing something...
It should be OK to reorder it above "search with [search engine]", though I think we might have put it where we did to try to keep text/selection-focused items together, which "take a screenshot" isn't really...
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Comment 2•3 years ago
|
||
(In reply to :Gijs (he/him) from comment #1)
Meridel, could you clarify what you'd like us to do? Because in the "context menu on a page" (slides 80 / 81) on https://docs.google.com/presentation/d/1Ufd0A3HsziyXXAjXYNH84P2bu7RdTxARsA0xpKmwIWs/edit?ts=606c5bdf#slide=id.gb7754f26c5_10_64 , there are separators around "take a screenshot", and a separator between it and "select all". From an engineering perspective, I assumed that this meant there should always be separators around it. It seems a little bit strange to have the separator between select all and take a screenshot for the page context menu, but to get rid of it when something is selected? Maybe I'm missing something...
It should be OK to reorder it above "search with [search engine]", though I think we might have put it where we did to try to keep text/selection-focused items together, which "take a screenshot" isn't really...
I realize I wasn't explicit about this: the "take screenshot" menu entry doesn't take a screenshot of just the selected text; it ends up opening the same UI as when the action is selected without a selection, hence my uncertainty around the grouping.
|
||
Comment 3•3 years ago
|
||
Thanks, Gijs, for the context, and thank you Bogdan for catching this inconsistency!
I could really argue this both ways (for or against having Take Screenshot in its own section). For that reason, I recommend we go with what is less work for ENG, which is to keep Take Screenshot in its own section, in both menus. I don't love the choppiness of the Text Selection context menu but this is not a major issue or seems worth the additional work. Deck is up-to-date.
|
|
||
Comment 4•3 years ago
|
||
Per feedback in the review presentation, let's still move the item further up in the menu, but without dropping the separators. Morphing for that.
|
|
Reporter | |
Updated•3 years ago
|
|
Assignee | |
Comment 5•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by michelle@masterwayz.nl: https://hg.mozilla.org/integration/autoland/rev/ac5c78a07de1 Move Take Screenshot label above "Search [search engine] for ..." item in the selection context menu r=Gijs
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 9•3 years ago
|
||
Verified that the position of Take Screenshot is in the right place (below Print and above Search) and the functionality is not affected by the change using Firefox 89.0b1 and latest Nightly 90.0a1 across platforms (Windows 10, macOS and Ubuntu 18.04).