Closed Bug 1703167 Opened 3 years ago Closed 3 years ago

about:devtools - bottom Learn More focus ring expands over whole section row instead of containing the string

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(firefox87 wontfix, firefox88 wontfix, firefox89 wontfix, firefox90 wontfix, firefox91 verified)

Status:
VERIFIED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox87 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- verified

People

(Reporter: cfogel, Assigned: danilo.fragoso)

References

Details

(Keywords: good-first-bug)

Attachments

(2 files)

fucosbard.png
43.49 KB, image/png
Details
Bug 1703167 - [devtools] Replaces aboutdevtools footer-link display to inline. r=honza
48 bytes, text/x-phabricator-request
Details | Review
Attached image fucosbard.png —

Affected versions

  • 89.0a1(2021-04-03), 88.0b7, 87.0;

Affected platforms

  • Windows 10, Ubuntu 20, macOS 10.13;

Steps to reproduce

  1. OS and Firefox set on dark theme;
  2. Access about:devtools
  3. Press the TAB key to reach the bottom Learn More hyperlink (from footer section)

Expected result

  • focus ring contains the desired string;

Actual result

  • focus ring expands on the whole row, instead of being limited to the selected string;

Regression range

  • not a regression, visible with initial implementation of page;

Additional notes

  • attached screenshot with the issue.

Thanks for the report, I can reproduce it on my machine.

Honza

Blocks: 1703799
Keywords: good-first-bug
Priority: -- → P3

Hey
I can work on this.

Assigned to you, thank you for helping.

Honza

Assignee: nobody → ian7991
Status: NEW → ASSIGNED
Has STR: --- → yes

Hello, I would love and appreciate to work on this?

Hi, this bug is already assigned to Ian.

@Ian: are you working on this, do you need any help?

Honza

Flags: needinfo?(ian7991)

@Honza
Apologies for the delayed response I got caught up, I had trouble setting up the dev environment on windows pc.

Flags: needinfo?(ian7991)

Thank for the response.

In case you didn't have time to finish this, please let us know.
heinleinjenn88 is interested to work on this.

Honza

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: ian7991 → nobody
Status: ASSIGNED → NEW

Hi, I would like to work on this.

Assignee: nobody → danilo.fragoso
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
Attachment #9229472 - Attachment description: Bug 1703167 - Replaces aboutdevtools footer-link display to inline. r=honza → Bug 1703167 - [devtools] Replaces aboutdevtools footer-link display to inline. r=honza

Replied in the Phabricator (r+)

Flags: needinfo?(odvarko)
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/957372929e10
[devtools] Replaces aboutdevtools footer-link display to inline. r=Honza

https://hg.mozilla.org/mozilla-central/rev/957372929e10

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

status-firefox90: --- → ?
Flags: qe-verify+

Reproduced the issue using an affected Nightly build 89.0a1 (20210405212812) on Windows 10x64.
Verified fixed with Firefox 91.0b8 (20210727185725) on Windows 10x64, macOS 10.13 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
status-firefox91: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: