Closed Bug 1702964 Opened 3 years ago Closed 3 years ago

The about:logins sorting is not visible when selected while a high contrast theme is enabled

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
Desktop
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- verified
firefox87 --- wontfix
firefox88 --- wontfix
firefox89 --- verified

People

(Reporter: cbaica, Assigned: emilio)

Details

(Keywords: regression)

Attachments

(2 files)

about logins sorting bug
38.02 KB, image/png
Details
Bug 1702964 - Remove workaround for bug that's fixed. r=Gijs,jaws
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr78+
Details | Review

Affected versions

  • Fx89.0a1
  • Fx87.0 RC
  • Fx88.0b7

Affected platforms

  • Windows 10

Steps to reproduce

  1. Enable a high contrast theme in Windows.
  2. Launch Firefox.
  3. Navigate to about:logins.
  4. Create a new login (invalid data can be used to do it for any website).
  5. Reach the Sort by dropdown, by circlying the elements of the page using the tab key.

Expected result

  • The selected dropdown is visible in high contrast mode.

Actual result

  • The dropdown is not visible while selected.

Regression range

  • This is a regression since it's reproducible on an RC build. Will come back with a regression range ASAP.

Additional notes

  • This is not related to proton, as it occurs in older builds without proton.
  • The dropdown is fully visible if the operation to open the drop-down is done using the mouse.
Severity: S3 → S4
Has STR: --- → yes
Has Regression Range: --- → no
QA Whiteboard: [qa-regression-triage]

I've ended up with the following regression range:

Has Regression Range: no → yes
Keywords: regressionwindow-wanted → regression

I can't repro this on Linux with high-contrast enabled fwiw.

Ah, I see what's going on.

Assignee: nobody → emilio

And which causes text to be invisible in high contrast mode.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19b49453b995
Remove workaround for bug that's fixed. r=jaws

https://hg.mozilla.org/mozilla-central/rev/19b49453b995

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89: fix-optional → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Flags: qe-verify+

Should we nominate this for ESR78 approval also?

Flags: needinfo?(emilio)

Comment on attachment 9216434 [details]
Bug 1702964 - Remove workaround for bug that's fixed. r=Gijs,jaws

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration:
  • User impact if declined: In hcm, text in a select element on about:logins focused by key Is invisible
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial css workaround removal.
  • String or UUID changes made by this patch: none
Flags: needinfo?(emilio)
Attachment #9216434 - Flags: approval-mozilla-esr78?
QA Whiteboard: [qa-regression-triage] → [qa-regression-triage][qa-triaged]

The issue is verified fixed using Fx89.0b11 on Windows 10. Waiting for an ESR build to verify the issue there as well.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
Flags: qe-verify+

Comment on attachment 9216434 [details]
Bug 1702964 - Remove workaround for bug that's fixed. r=Gijs,jaws

Approved for 78.11esr, thanks.

Attachment #9216434 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+

Marking the issue as verified fixed on Fx78.11.0ESR as well.

status-firefox-esr78: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: