Not all about pages have the new proton Firefox chiclet
Categories
(Firefox :: Address Bar, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox89 | --- | wontfix |
firefox90 | --- | affected |
People
(Reporter: cbaica, Unassigned)
References
Details
(Whiteboard: [proton-address-bar])
Attachments
(1 file)
16.26 KB,
image/png
|
Details |
Affected versions
- Fx89.0a1
Affected platforms
- Windows 10
- Ubuntu 18.04
- macOS 10.15
Steps to reproduce
- Launch Firefox.
- Navigate to any of the following about pages:
about:about
about:buildconfig
about:checkerboard
about:compat
about:debugging#/setup
about:devtools
about:loginsimportreport
about:logo
about:memory
about:mozilla
about:networking
about:performance
about:plugins
about:policies
about:processes
about:profiles
about:profiling
about:robots
about:serviceworkers
about:studies
about:sync-log
about:telemetry
about:url-classifier
about:webrtc
Expected result
- Firefox chiclet is correctly displayed in the address bar.
Actual result
- Firefox chiclet is missing from the listed pages.
Regression range
This is not a regression as it's a new design.
Additional notes
- Some about pages like about:preferences, about:support have the chiclet correctly displayed.
- The mentioned pages have a magnifying glass icon instead of the new chiclet.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Comment 1•3 years ago
•
|
||
IIRC the presence of the "brand box" on those pages is controlled by their permissions, in particular only pages running with chrome privilege have the brand box.
This is likely not a regression in Proton, because those same pages don't show the brand text in Photon or any previous themes.
https://searchfox.org/mozilla-central/source/browser/components/about/AboutRedirector.cpp#110 and if I understood correctly the pages with the badge are the ones without nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT
Based on that, we set a "chromeui" attribute here:
https://searchfox.org/mozilla-central/rev/54f37fc1ac0f98b590af51e01ce82bb74179bf63/browser/base/content/browser-siteIdentity.js#777-779
If we want all the pages to show it, we should probably not rely anymore on the chrome privilege and not use the "chromeui" attribute. In the past there have been discussions about showing branded pages for everything or just for chrome privileged pages.
Johann, do you remember the reasons for which we decided to show the brand badge only on _isSecureInternalUI, or reasons for which we should not extend that to every about page? I think WebExtensions cannot register new about: pages.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 2•3 years ago
|
||
Thanks :Virtual, I agree that this bug is basically Bug 1567443 and fixing that we get this for free. I'm tempted to just mark as a dupe, but let's keep this around as a reminder for the future.
Updated•3 years ago
|
Comment 4•3 years ago
|
||
We're hoping to take another stab at bug 1567443 soon :)
Description
•