[Proton] DoH panel button is not named correctly
Categories
(Firefox :: Messaging System, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox87 | --- | unaffected |
| firefox88 | --- | unaffected |
| firefox89 | --- | affected |
People
(Reporter: cgeorgiu, Unassigned)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-door-hangers][priority:2c])
Attachments
(2 files)
Screenshot 2021-04-02 at 14.30.20.png
Affected versions
- latest Nightly 89.0a1
Affected platforms
- Windows 10 x64
- macOS 10.15
- Ubuntu 18.04 x6
Preconditions
Firefox is launched.
The following prefs are set to true in about:config:
- browser.proton.enabled,
- browser.proton.doorhangers.enabled (for preliminary testing this also required, until the work is moved to the main pref).
- browser.newtabpage.activity-stream.asrouter.devtoolsEnabled is also set to true
Steps to reproduce
- In a new tab click click on the "Expand devtools" icon.
- Search in the page the following string: DOH_ROLLOUT_CONFIRMATION_89
- Click on the "Show" button.
- Observe the "OK, Got it" button.
Expected result
- "OK, Got it" button is named "Okay".
Actual result
- "OK, Got it" button is not named "Okay", as per specs.
Suggested Severity
- S3, since this won't affect the users.
Regression range
- Not a regression. This copy change was introduced with Fx89 Nightly.
Additional notes
- please see the attached screenshots.
|
Reporter | |
Comment 1•3 years ago
|
||
Image with the panel according to specifications.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 2•3 years ago
|
||
The string for DOH_ROLLOUT_CONFIRMATION_89 was fixed in bug 1695320. I've verified this with your STR. However DOH_ROLLOUT_CONFIRMATION still has the old string.
|
|
Reporter | |
Comment 3•3 years ago
•
|
||
Hi Michael! It seems that on my side the button is properly changed into "Okay" on latest Nightly 89.0a1.
(In reply to Michael Kohler [:mkohler] from comment #2)
However DOH_ROLLOUT_CONFIRMATION still has the old string.
Jut to make sure, did you check DOH_ROLLOUT_CONFIRMATION panel or DOH_ROLLOUT_CONFIRMATION_89, only the one from 89 should contain the string change.
|
|
||
Comment 4•3 years ago
|
||
(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #3)
(In reply to Michael Kohler [:mkohler] from comment #2)
However DOH_ROLLOUT_CONFIRMATION still has the old string.
Jut to make sure, did you check
DOH_ROLLOUT_CONFIRMATIONpanel orDOH_ROLLOUT_CONFIRMATION_89, only the one from 89 should contain the string change.
I checked both: DOH_ROLLOUT_CONFIRMATION has the old string, DOH_ROLLOUT_CONFIRMATION_89 has the new one. So everything works as expected.
Description
•