Open Bug 1702702 Opened 3 years ago Updated 1 year ago

about:addons - adjust thickness for theme selector line for default theme names to be the same as on custom ones

Categories

(Toolkit :: Add-ons Manager, defect, P2)

Unspecified
All
defect

Tracking

()

Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- wontfix
firefox89 --- wontfix

People

(Reporter: cfogel, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-aboutpages] [priority:2c])

Attachments

(2 files)

Attached image addons-themes.png

Affected versions

  • 88.0b4, 89.0a1(2021-04-01)

Affected platforms

  • Windows 10, Ubuntu 20;

Steps to reproduce

  1. Launch Firefox, access about:addons
  2. Click on the Themes section;
  3. Press the TAB key to navigate inside the page;

Expected result / Actual result

  • elements highlighted;

Enhancement suggestion

  • for the Default themes (Default, Firefox AlpenGlow, Light/Dark) the theme name border is half the width as the other borders (name buttons);
  • the suggestion would be, that at least for this page to have them with the same thickness;

Regression range

  • First bad: 2021-03-29;
  • Last good: 2021-03-28;
  • Pushlog: URL
  • Potential regressor: mozregression points towards bug 1699250;
  • prior to this change, the focus was indicated by a dotted line (some builds had missing sides on borders);

Additional notes

  • attached screenshot to illustrate the suggestion;
  • reproducible with Proton prefs on/off.
Has Regression Range: --- → yes
Has STR: --- → yes
Regressed by: 1699250

As "regressor" points towards Proton prep-work updating keywords as well.

Blocks: 1694394
Whiteboard: proton-aboutpages
Whiteboard: proton-aboutpages → [proton-aboutpages]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Type: enhancement → defect

Reproduced this issue on macOS 10.15.7 as well , using Nightly 89.0a1 (2021-04-06)

The regressing bug landed in 89 - if this does reproduce in Beta, can we re-examine the regression range?

Flags: needinfo?(cristian.fogel)
Priority: -- → P2
Whiteboard: [proton-aboutpages] → [proton-aboutpages] [priority:2c]
Attached image Screenshot_2.png

The previous implementation, considered when taking the regression range can be seen in the attachment.
In case mozregression points towards the wrong bug, linking the pushlog from the day to list all the patches pushed:

Flags: needinfo?(cristian.fogel)

The new regression range is still from a week after 88 went to Beta. I'm still confused as to what 88 is doing here, but regardless the issue is minor enough that it'd be a wontfix given that we're in RC week already.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: