Screenshot button doesn't have a hover effect if placed in Overflow Menu
Categories
(Firefox :: Toolbars and Customization, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox87 | --- | unaffected |
| firefox88 | --- | fixed |
| firefox89 | --- | verified |
People
(Reporter: atrif, Assigned: itiel_yn8)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression, Whiteboard: [proton-toolbar])
Attachments
(2 files)
|
168.81 KB,
image/gif
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
screenshots.gif
Affected versions
- 89.0a1 (20210331092207)
- 88.0b5 (20210330185720)
Affected platforms
- Windows 10x64
- macOS 10.15.7
- macOS 11.2
- Ubuntu 20.04
Steps to reproduce
- Open Firefox and add the Screenshot button to the overflow menu.
- Open a page and hover over the Screenshot button.
Expected result
- Hover effect is active.
Actual result
- No hover effect
Regression range
- Screenshot button was added to the toolbar by bug 1691464 so I think this is what caused this behavior so this is not a regression.
Notes
- Attached a screen recording.
- This happens with proton enabled and disabled as well.
- The button functions properly.
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9fc503606372 Fix Screenshots button hover state in the overflow panel r=emalysz
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
|
||
Comment 4•3 years ago
|
||
The patch landed in nightly and beta is affected.
:itiel_yn8, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
|
|
Reporter | |
Comment 5•3 years ago
|
||
The hover effect is now visible on the Screenshot button while if placed in the Overflow menu. Verified with Firefox 89.0a1 (20210405094633) with proton enabled and disabled as well.
Comment on attachment 9213125 [details]
Bug 1702220 - Fix Screenshots button hover state in the overflow panel r?emalysz,sfoster
Beta/Release Uplift Approval Request
- User impact if declined: Missing hover/active states on the Screenshots button when placed in the overflow menu
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple JS change
- String changes made/needed:
|
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9213125 [details]
Bug 1702220 - Fix Screenshots button hover state in the overflow panel r?emalysz,sfoster
Approved for 88.0b8.
|
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
Description
•