nsIndexedToHTML generated views - focus ring for directories only shows the right margin
Categories
(Core :: Networking, defect, P3)
Tracking
()
People
(Reporter: cfogel, Assigned: valentin)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(2 files)
Screenshot from 2021-03-31 13-31-26.png
Affected versions
- 75.0, 88.0b3, 89.0a1(2021-03-28);
Affected platforms
- Ubuntu 20,
Steps to reproduce
- Launch Firefox, access about:sync-log
- Click on the [Up to higher level directory] button;
- Press the TAB key to reach to the failed/logs/toFetch list elements;
Expected result
- focus ring around string displayed;
Actual result
- only right side of the interrupted ring displayed;
Regression range
- will check when time permits it, since it's somewhat of an edge case scenario;
Additional notes
- attached screenshot to best illustrate the issue.
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
about:sync-log just uses the builtin directory viewer as implemented in https://searchfox.org/mozilla-central/source/netwerk/streamconv/converters/nsIndexedToHTML.cpp. I suspect this is never going to be fixed.
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
Seems like quite a minor issue, but it's very easy to fix. CSS isn't my strong point, but this doesn't appear to break anything.
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/13662d978347 nsIndexedToHTML generated views - focus ring for directories only shows the right margin r=Gijs
|
|
||
Comment 5•3 years ago
|
||
(In reply to Mark Hammond [:markh] [:mhammond] from comment #1)
I suspect this is never going to be fixed.
Famous last words :) I'd like to think that my "temping fate" had some impact :)
(In reply to Pulsebot from comment #4)
Pushed by valentin.gosu@gmail.com:
Thank you!
|
|
Assignee | |
Comment 6•3 years ago
|
||
I should have replied with "Challenge accepted!" 🙂
In any case, thanks for pointing me towards the file that needed fixing.
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 8•3 years ago
|
||
I have reproduced the issue using STR from comment 0, on an affected Nightly build 2021-03-28.
The fix was verified using the latest Nightly 90.0a1 (2021-05-09) and Firefox 89.0b9 (2021-05-06) on Windows 10x64 and Ubuntu 20.04.
We could not verify this on macOS 10.15 because you cannot navigate to the folder section (tree) using TAB.
Description
•