about:policies - Documentation list TAB select should bring the cell in better focus while cycling through the list
Categories
(Firefox :: Enterprise Policies, defect)
Tracking
()
People
(Reporter: cfogel, Assigned: mkaply)
Details
Attachments
(2 files)
182.77 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr78+
|
Details | Review |
Affected versions
- 88.0b3, 89.0a1(2021-03-28);
Affected platforms
- Ubuntu 20, Windows 10;
Steps to reproduce
- Launch Firefox, access about:policies#documentation
- Press the TAB key to navigate across the list;
Expected result
- list elements are visible and not covered by anything;
Enhancement suggestion
- cell can be centered and not just the link part brought up at the min-position;
- with Tab cycle when second to last item is cycled it should be displayed, page "auto-scrolling early" thus reaching in the reported scenario (only on the last item from the list)
Actual result
- the URL indicator overlaps the Documentation link;
Regression range
- with 75.0 the TAB selection was not reaching inside the page, so it was implemented as this from the get-go most likely;
- in regards to it, marking the bug as an enhancement;
Additional notes
- attached screenshot to better illustrate the issue; observe the bottom part of it, with the STR the link would be covered with the URL string.
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
I don't think there's anything policy can do about this. This is just a web page and this is the behavior of Firefox.
This belongs in DOM to find out:
-
Why doesn't the popup with the URL go away after some timeout?
-
Should we scroll more when a link is at the bottom of the page?
Comment 2•3 years ago
|
||
I recall a mention of an issue of sounding like this last week. Masayuki, do you already know what this is about?
Comment 3•3 years ago
|
||
I see this in 87 too. So, this is not a recent regression. Layout people might have some idea for solving this issue.
Comment 4•3 years ago
|
||
Just specifying scroll-padding property on #main-content would solve the issue that the list elements covered by something.
I am not sure about the suggestion in comment 0 though.
Assignee | ||
Comment 5•3 years ago
|
||
Updated•3 years ago
|
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/88135a2965e4 Stop URL popup from overlapping policy links. r=emalysz
Comment 7•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Comment 8•3 years ago
|
||
The patch landed in nightly and beta is affected.
:mkaply, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 9•3 years ago
|
||
Comment on attachment 9217223 [details]
Bug 1702154 - Stop URL popup from overlapping policy links. r?emalysz!
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only, just a nice cleanup
- User impact if declined: Can't tab through policies (accessibility issue)
- Fix Landed on Version: 90
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): CSS only change for policy.
- String or UUID changes made by this patch:
Comment 10•3 years ago
|
||
Comment on attachment 9217223 [details]
Bug 1702154 - Stop URL popup from overlapping policy links. r?emalysz!
Approved for 78.12esr.
Comment 11•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Updated•3 years ago
|
Comment 12•3 years ago
•
|
||
Reproduced the issue in release 89 using Windows 10.
Verified - Fixed in Beta 90.0, latest Nightly 91.0a1 (2021-07-09) and 78.12.0esr using Windows 10 and Ubuntu 20. The URL popup don't overlap the policy links anymore.
Description
•