Closed Bug 1702150 Opened 3 years ago Closed 3 years ago

about:policies - TAB select skips the Section links

Categories

(Firefox :: Enterprise Policies, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox-esr78 --- verified
firefox87 --- wontfix
firefox88 --- wontfix
firefox89 --- verified

People

(Reporter: cfogel, Assigned: mkaply)

References

Details

Attachments

(2 files)

Affected versions

  • 75.0, 88.0b3, 89.0a1(2021-03-28);

Affected platforms

  • Ubuntu 20, Windows 10;

Steps to reproduce

  1. Launch Firefox, access about:policies
  2. Press the TAB key to reach the section pickers (Active/Documentation;

Expected result

  • TAB navigation reaches at least one of the above mentioned;

Actual result

  • TAB navigation skips the Section and jumps to buttons inside it

Regression range

  • most likely not a regression, would confirm when possible;
  • setting this as an enhancement until then;

Additional notes

  • if there are active policies or the Documentation is selected tab navigation goes through the available links;
  • attached a screenshot to illustrate the section;
  • reproduces with proton prefs both on/off.
Has Regression Range: --- → no
Has STR: --- → yes

Need to add tabindex to the divs.

QA Whiteboard: [qa-regression-triage]

This is not a regression, the same behavior is present since the page implementation (Fx 63.0a1).

Has Regression Range: no → ---
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #9215851 - Attachment description: Bug 1702150 - Add categories to tabindex and make enter work. r?emalysz! → Bug 1702150 - Add tabindex to categories and make enter work. r?emalysz!
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/6a1d0d1dbae7
Add tabindex to categories and make enter work. r=emalysz
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Comment on attachment 9215851 [details]
Bug 1702150 - Add tabindex to categories and make enter work. r?emalysz!

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policies only fix, compat with 89
  • User impact if declined: Accessibility issue - can't access policy docs with keyboard
  • Fix Landed on Version: 89
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very low risk change, just would be nice to have for consistency with 89
  • String or UUID changes made by this patch:
Attachment #9215851 - Flags: approval-mozilla-esr78?

Comment on attachment 9215851 [details]
Bug 1702150 - Add tabindex to categories and make enter work. r?emalysz!

approved for 78.11esr

Attachment #9215851 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
Flags: qe-verify+
QA Whiteboard: [qa-regression-triage] → [qa-regression-triage][qa-triaged]

Hello,

I have reproduced the issue using STR from comm 0, on an affected Nightly build 2021-03-30.
I've verified the fix on 89.0b5 (2021-04-27). Tests were performed on Ubuntu 20.04 and Windows 10.

Thanks!

Status: RESOLVED → VERIFIED
Flags: qe-verify+

I've also verified the fix on 78.11.0esr (20210422135041), on both Windows10 and Ubuntu 20.04.

Should this fix also be found in 78.10.1 esr?
I'm asking this because I've verified on both Windows 10x64 and Ubuntu 20.04 and this issue still reproduces with that build.

Flags: needinfo?(mozilla)

No, this fix was not in the 78.10 ESR.

Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: