Closed Bug 1702139 Opened 3 years ago Closed 3 years ago

about:performance - close button [ x ] icon not centered

Categories

(Toolkit :: Performance Monitoring, defect)

Product:
Toolkit
Component:
Performance Monitoring
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- verified
firefox89 --- verified

People

(Reporter: cfogel, Assigned: itiel_yn8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot from 2021-03-31 10-51-49.png
32.45 KB, image/png
Details
Bug 1702139 - Fix appearance of about:performance action icons.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review

Affected versions

  • 89.0a1(2021-03-28), 88.0b3;

Affected platforms

  • Windows 10, Ubuntu 20;

Steps to reproduce

  1. Launch Firefox, access about:performance
  2. Hover over any process;
  3. Hover over the [ x ] Close button;

Expected result

  • [ x ] close button centered;

Actual result

  • [x ] - not centered;

Regression range

  • will check and update asap;
  • Last good: confirming with 75.0 that button is ok;

Additional notes

  • attached screenshot with the issue.
Has Regression Range: --- → no
Has STR: --- → yes

Regression from bug 1696202.

Has Regression Range: no → yes
status-firefox87: --- → unaffected
status-firefox-esr78: --- → unaffected
Keywords: regressionwindow-wanted
Regressed by: 1696202
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fdf9f0e68a58
Fix appearance of about:performance action icons. r=harry

https://hg.mozilla.org/mozilla-central/rev/fdf9f0e68a58

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

The patch landed in nightly and beta is affected.
:itiel_yn8, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(itiel_yn8)
Blocks: 1703509

Comment on attachment 9212936 [details]
Bug 1702139 - Fix appearance of about:performance action icons.

Beta/Release Uplift Approval Request

  • User impact if declined: Uncentered and unpolished action buttons in about:performance
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1703509
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS-only changes that simplify the action button code.
    Bug 1703509 fixes something I missed in this bug.
  • String changes made/needed:
Flags: needinfo?(itiel_yn8)
Attachment #9212936 - Flags: approval-mozilla-beta?

Verified with 89.0a1 (2021-04-07).

status-firefox89: fixed → verified

Comment on attachment 9212936 [details]
Bug 1702139 - Fix appearance of about:performance action icons.

Approved for 88.0b9.

Attachment #9212936 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

The issue is verified fixed in Fx88.0b9 and Fx89.0a1 on Windows 10 and Ubuntu 18.04. The close button is now correctly centered.

Status: RESOLVED → VERIFIED
status-firefox88: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: