about:devtools - focus ring of checkbox for GDPR conrifmation truncated when TAB-selected
Categories
(DevTools :: General, defect, P5)
Tracking
(firefox-esr78 wontfix, firefox87 wontfix, firefox88 wontfix, firefox89 verified)
People
(Reporter: cfogel, Assigned: vishal.vikal.88)
References
Details
(Keywords: good-first-bug, regression)
Attachments
(6 files)
Screenshot from 2021-03-31 09-38-39.png
Affected versions
- 89.0a1(2020-03-28), 88.0b4, 75.0;
Affected platforms
- Ubuntu 20, Windows 10
Steps to reproduce
- Launch Firefox, access about:devtools
- Click inside the Email input;
- Press the TAB key to select the checkbox for GDPR confirmation;
- can zoom in for better visibility;
Expected result
- checkbox highlight is displayed as expected;
Actual result
- checkbox highlight is cut by the image near it;
Regression range
- last good: 2019-09-08;
- first bad: 2019-09-09;
- pushlog URL;
Additional notes
- attached screenshot with the issue;
|
Reporter | |
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
Thanks for the report Cristian. I can also reproduce this on Win 10 (screenshot attached).
Also, the registration for Developer Newsletter is currently broken (see bug 1693255)
Honza
|
|
||
Comment 2•3 years ago
|
||
This looks like good first bug:
-
The checkbox is declared here:
https://searchfox.org/mozilla-central/rev/9043e515e9608cc55b252a40cb2dfb6f767bcffd/devtools/startup/aboutdevtools/aboutdevtools.xhtml#73 -
The image is in the same file
https://searchfox.org/mozilla-central/rev/9043e515e9608cc55b252a40cb2dfb6f767bcffd/devtools/startup/aboutdevtools/aboutdevtools.xhtml#50
It might be just CSS fix.
Honza
|
|
Reporter | |
Comment 3•3 years ago
|
||
Thanks for the input Honza. Have updated the regression section as well in the meanwhile.
|
|
Reporter | |
Comment 4•3 years ago
•
|
||
Attaching a screenshot to illustrate the pre-Proton state (Win10).
|
||
Updated•3 years ago
|
|
|
||
Comment 8•3 years ago
|
||
Assigned to you, thanks for the help.
Honza
|
Assignee | |
Comment 10•3 years ago
|
||
Second screen shot of the fixed issue.
|
|
Assignee | |
Comment 11•3 years ago
|
||
Hello Honza,
I fixed the issue can write the patch for this issue.
Request Information Honza.
Thanks
|
|
Assignee | |
Comment 12•3 years ago
|
||
Depends on D110659
|
|
Assignee | |
Comment 13•3 years ago
|
||
Hello Sir I fixed the checkbox cut off issue plese review it.
|
||
Updated•3 years ago
|
|
||
Comment 14•3 years ago
|
||
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6d2b9780854 [devtools] Fix the checkbox cut by the image near it issue. r=Honza
|
|
||
Comment 15•3 years ago
|
||
Hi Vishal,
(In reply to vishal from comment #11)
Hello Honza,
I fixed the issue can write the patch for this issue.
Thank you for the patch I pushed the changes to autoland repo. It's should be merged with the Mozilla Central (m-c) repository soon.
Request Information Honza.
You need to use the fields at the bottom of the page:
- Check the "Request information from" checkbox
- Insert email of the person you need info from.
- Press "Save Changes" just like when you are posting a comment.
Honza
|
||
Comment 16•3 years ago
|
||
| bugherder | ||
|
|
||
Updated•3 years ago
|
|
||
Comment 17•3 years ago
|
||
The issue is verified fixed in Fx89.0a1 on Windows 10 and Ubuntu 18.04. The button border is no longer cut off.
|
|
||
Updated•3 years ago
|
Description
•