Search bar focus on about pages not rounded properly at edges appearing cut
Categories
(Firefox :: General, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox87 | --- | wontfix |
| firefox88 | --- | wontfix |
| firefox89 | --- | fixed |
People
(Reporter: cfogel, Assigned: emilio)
Details
(Keywords: regression)
Attachments
(5 files)
Screenshot from 2021-03-30 10-52-09.png
Affected versions
- 89.0a1(2021-03-28), 88.0b4;
Affected platforms
- Ubuntu 20, Windows 10;
Steps to reproduce
- Launch Firefox;
- Access about:preferences or about:addons
- Zoom in;
- Click inside the top-Search bar;
Expected result
- no issues;
Actual result
- blue focus-line is not filled @ the edges;
Regression range
- will check and provide one asap;
Additional notes
- visible with Proton prefs both on/off;
- other pages might also be affected, if they use the same search bar;
- attached screenshot to best illustrate the issue (zoom in for better visibilty).
|
Reporter | |
Updated•3 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
This is a minor cosmetic issue, but CSS is not the right component for this. This is a web painting / graphics issue. Though the front-end could fix it with a minor outline-offset.
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
I checked the math and it doesn't seem to be some sort of precision issue, and the math looks right to me...
Markus, it seems we're anti-aliasing with the background, do you know if/how we could avoid that? How do we avoid that to avoid this issue when drawing borders to avoid bleeding between backgrounds and borders of the same color?
|
|
Assignee | |
Comment 3•3 years ago
|
||
Ah, I guess the answer is "we don't, and we're just over-drawing", I see the same with background-clip: padding-box:
<!doctype html>
<div style="width: 100px; height: 100px; border: 2px solid black; border-radius: 6px; background: black; background-clip: padding-box;"></div>
So I guess a reasonable way to fix this would be to do this in the front-end.
|
||
Updated•3 years ago
|
|
||
Comment 4•3 years ago
|
||
Hello! Searched for a regression range using the attached test case in comment 1:
Last good revision: 566f81bfa373512b41c1a47962e21a06078d7bf8
First bad revision: fbe159e50e821029e512c4a5ec53ded1b875cb9c
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=566f81bfa373512b41c1a47962e21a06078d7bf8&tochange=fbe159e50e821029e512c4a5ec53ded1b875cb9c
|
|
Assignee | |
Comment 5•3 years ago
|
||
Can you post an screenshot of the "good" version?
|
|
||
Comment 6•3 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)
Can you post an screenshot of the "good" version?
Hello Emilio this was taken as a good version because the testcase it was as same as on Chrome now. If this is not correct please announce me. Thank you!
|
|
||
Comment 7•3 years ago
•
|
||
Opening the test case with the latest nightly shows rounded edges.
|
|
Assignee | |
Comment 8•3 years ago
|
||
Well that was the intended effect of the bug in question, that's a progression :)
|
|
||
Comment 9•3 years ago
|
||
Oh sorry for that. I misinterpreted the test case. Adding the flags back and I will search for a proper regression range this time if there is one. Thank you for the clarification.
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 10•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 11•3 years ago
|
||
I'll just fix it on the frontend. It's not super-clear clear what the right answer is for the general case...
|
||
Comment 12•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a42e5cb32709 Prevent antialising between the border and the outline in content pages. r=Gijs
|
||
Comment 13•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
Description
•