Closed Bug 1701749 Opened 3 years ago Closed 3 years ago

Double-tap to zoom seems to apply zoom level only at the beginning of a div which encloses plain text

Categories

(Core :: Panning and Zooming, defect)

Product:
Core
Component:
Panning and Zooming
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: emilghitta, Assigned: tnikkel)

References

Details

Attachments

(2 files)

index.html
2.53 KB, text/html
Details
Bug 1701749. When computing the double tap rect if there is a overflow rect that contains the bounding client rect use that. r?emilio
48 bytes, text/x-phabricator-request
Details | Review
Attached file index.html —

Affected versions

  • Firefox 89.0a1 (BuildId:20210328213901)
  • Firefox 88.0b4 (BuildId:20210328185936) - disabled

Affected platforms

  • macOS 10.14
  • macOS 11.1

Unaffected platforms

  • Windows 10 64bit
  • Ubuntu 20.04

Preconditions

  • Have the following pref set to true: apz.mac.enable_double_tap_zoom_touchpad_gesture

Steps to reproduce

  1. Launch Firefox.
  2. Access the attached test case.
  3. Try double tapping at the middle of the div content.

Expected result

  • The zoom is successfully applied inside the desired area (as in Safari).

Actual result

  • The zoom is applied at the top of the div content (as in Chrome).

Regression Range

  • I don’t think that this is a regression.

Notes

  • For further information regarding this issue, please observe the following link (Mozilla account needed).
  • I'm not sure how many users could encounter this behavior. Not sure if enclosing plain text inside divs (no semantical meaning) for some reasons is a practice out in the wild.
Severity: -- → S4

I'm not sure if this is better overall or not, it's better for the testcase in this bug (a div with a large amount of visible overflow).

This code is a direct port of javascript code, so it only had the option of using getBoundingClientRect.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0df81346b2b
When computing the double tap rect if there is a overflow rect that contains the bounding client rect use that. r=emilio
Flags: needinfo?(tnikkel)
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee155916d1e3
When computing the double tap rect if there is a overflow rect that contains the bounding client rect use that. r=emilio

https://hg.mozilla.org/mozilla-central/rev/ee155916d1e3

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

This issue is verified fixed using Firefox 89.0a1 (BuildId:20210414093129) on macOS 10.15

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
Depends on: 1707557
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: