Closed Bug 1701600 Opened 3 years ago Closed 1 year ago

about:support - Troubleshoot mode button not contained by top section

Categories

(Firefox :: Theme, defect)

defect

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox-esr91 --- wontfix
firefox-esr102 --- wontfix
firefox89 --- wontfix
firefox104 --- wontfix
firefox105 --- wontfix
firefox106 --- wontfix
firefox107 --- wontfix
firefox111 --- wontfix
firefox112 --- wontfix
firefox113 --- verified
firefox114 --- verified

People

(Reporter: cfogel, Assigned: itsanand.roy11, Mentored, NeedInfo)

References

(Regression)

Details

(Keywords: good-first-bug, regression, Whiteboard: [lang=css])

Attachments

(11 files)

Attached image Screenshot(4).png

Affected versions

  • 89.0a1 (2021-03-28)

Affected platforms

  • Ubuntu 20, Windows 10;

Steps to reproduce

  1. Launch Firefox and access about:support;
  2. Zoom in, resize the browser so it takes up half-width of screen (or less);
  3. Scroll down;

Expected result

  • buttons are contained in sections/separators;

Actual result

  • [Troubleshoot mode...] button is not contained in the Give Nightly a Tune up section;

Regression range

  • will check and provide one asap;

Additional notes

  • reproducible with proton prefs both on/off;
  • attached screenshot with the issue.
Has Regression Range: --- → no
Has STR: --- → yes

It seems that the offset issue appeared first on the "Restart with Add-ons Disabled" button. Mozregression pinpointed me to:
Last good revision: 1cd85123fd5501651c0c0144344456a50b760e13
First bad revision: 4dcdf646c322a5636037bd764441b11794bd2771

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1cd85123fd5501651c0c0144344456a50b760e13&tochange=4dcdf646c322a5636037bd764441b11794bd2771

Has Regression Range: no → yes
Summary: about:suppot - Troubleshoot mode button not contained by top section → about:support - Troubleshoot mode button not contained by top section

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Theme
Regressed by: 1694427

Set release status flags based on info from the regressing bug 1694427

:Gijs, since you are the author of the regressor, bug 1694427, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(gijskruitbosch+bugs)

To fix this we could just change the width: 30% on the containing box to min-width: 30% so it doesn't enforce a width that is too narrow for the contents. That will also stop the buttons wrapping, however. Perhaps a more elaborate solution can be found. Either way it's purely a CSS issue, so marking this a mentored issue in the hope someone can pick it up.

Mentor: gijskruitbosch+bugs
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: good-first-bug
Whiteboard: [lang=css]

Hi, I'd like to take this on if no one else is working on it yet.

I made some styling changes a bit beyond what :Gijs suggested. Once the screen width is small enough, the "action box" (the box containing the three buttons) goes inline between the subtitle and the copy buttons. For smaller screens, I think this improves it compared to having them side-by-side.

I put the action box above the copy buttons since those buttons are related to the tables below. For the same reason, on larger screens, I decided to see what it looks like with the copy buttons pushed to the bottom, closer to the tables - to me it makes it a bit more clear what you're copying (this is unrelated to this ticket though, so I can remove it).

I'm open to feedback of course! I'll submit a patch tomorrow/within a few days, and I'll try to post a screenshot for now. This is my first time using Bugzilla and trying to contribute to Firefox and I'm still figuring everything out, please let me know if I missed anything.

(In reply to Avery [:avery] from comment #6)

Hi, I'd like to take this on if no one else is working on it yet.

I made some styling changes a bit beyond what :Gijs suggested. Once the screen width is small enough, the "action box" (the box containing the three buttons) goes inline between the subtitle and the copy buttons. For smaller screens, I think this improves it compared to having them side-by-side.

I put the action box above the copy buttons since those buttons are related to the tables below. For the same reason, on larger screens, I decided to see what it looks like with the copy buttons pushed to the bottom, closer to the tables - to me it makes it a bit more clear what you're copying (this is unrelated to this ticket though, so I can remove it).

I'm open to feedback of course! I'll submit a patch tomorrow/within a few days, and I'll try to post a screenshot for now. This is my first time using Bugzilla and trying to contribute to Firefox and I'm still figuring everything out, please let me know if I missed anything.

The screenshot looks good to me - thank you for working on this. We normally assign mentored bugs when a patch is attached. :-)

Make sure that about:profiles and any other pages using the styling from info-pages.css don't regress with your changes (I expect they won't, but it wouldn't hurt to check).

Assignee: nobody → mozilla
Status: NEW → ASSIGNED

The "refresh" item in the action box on about:support, when it's shown, has no
margin-top. If it isn't shown, the next items do have a margin. This commit
removes the margin from the new first item when the refresh item isn't shown.

I also removed the margin in the action box on the about:profiles page to make
it consistent with about:support.

Depends on D156924

Set release status flags based on info from the regressing bug 1694427

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: mozilla → nobody
Status: ASSIGNED → NEW

can I work on this as my first bug or is this closed?

Thanks!

(In reply to Tal from comment #13)

can I work on this as my first bug or is this closed?

Thanks!

It's not closed, so if you can update the patches Avery attached here that would work.

Hey, I made some changes similar to what Avery did.

Attached image About:profile

Also brought the action box below the subtitles in about:profiles

(In reply to Anand Roy from comment #15)

Hey, I made some changes similar to what Avery did.

Please put up patches on phabricator - I can't really review the screenshots because I don't know what code changes you made to achieve those results.

Assignee: nobody → itsanand.roy11
Status: NEW → ASSIGNED

Depends on D172206

I tested the patch with the "accented" pseudolocale and zooming the text and set the media query size according to it

Sorry, I wasn't able to rebase it to central. Please check the last one.

Hey, can you please check my last submitted patch. It is properly rebased and doesn't have extra codes.

Attachment #9322292 - Attachment description: Bug 1701600 - Fixed the width of action box in about:support and about:profiles in smaller screen. r=Gijs → WIP: Bug 1701600 - Fix the width of the action box in about:support and
Attachment #9322292 - Attachment description: WIP: Bug 1701600 - Fix the width of the action box in about:support and → Bug 1701600 - Fix the width of the action box in about:support and about:profiles for smaller screens, r=Gijs

Please check the above patch.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8a603e67430b
Fix the width of the action box in about:support and about:profiles for smaller screens, r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Regressions: 1823022
QA Whiteboard: [qa-113b-p2]

Anand Roy, since this bug has been fixed, can you please abandon the other patches you've submitted here?

Flags: needinfo?(itsanand.roy11)

Reproducible on a 2023-03-14 Nightly build on Windows 10.
Verified as fixed on Firefox 113.0(build ID: 20230501151611) and Nightly 114.0a1(build ID: 20230501093846) on Windows 10, Ubuntu 22, macOS 12.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-113b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: