Affected versions

• Fx89.0a1

Affected platforms

• Ubuntu 18.04

Preconditions
The following prefs are enabled in about:config

• browser.proton.enabled true
• browser.proton.toolbar.enabled
• browser.proton.urlbar.enabled true

Steps to reproduce

1. Launch Firefox.
2. Focus something in page and observer the address bar.
3. Focus the address bar and input a term (e.g. 'cat') so the address bar is expanded with search terms.

Expected result

• The address bar should not have a border.

Actual result

• The address bar has a grey border.

Regression range

• This is not a regression as it's related to a new proton design.

Additional notes

• The address bar does not have a border if either the Proton Light or Proton Dark themes are enabled.
• Firefox has the default theme enabled.
• The same grey border is also visible in Windows 10, if the user has 'Dark' chosen in his OS colors.

By default we respect system colors on Linux, I think the border is from this rule:
https://searchfox.org/mozilla-central/rev/6309f663e7396e957138704f7ae7254c92f52f43/browser/themes/linux/browser.css#192-195

I wonder if we'd want to omit it for design reasons. While it may not be strictly necessary, we should then be confident there will be enough contrast between the toolbar and the input field.

(In reply to Marco Bonardo [:mak] from comment #1)

By default we respect system colors on Linux, I think the border is from this rule:
https://searchfox.org/mozilla-central/rev/6309f663e7396e957138704f7ae7254c92f52f43/browser/themes/linux/browser.css#192-195

I wonder if we'd want to omit it for design reasons. While it may not be strictly necessary, we should then be confident there will be enough contrast between the toolbar and the input field.

I think we should but NI_ing Amy here for validation.

yes, but it's not just a design decision, there are technical reasons for which Linux doesn't strictly follow the design, mostly the variety of Linux managers themes, and since we don't force the colors on toolbars and fields we may not have enough contrast without a border.
Dao, what do you think?

Hi,

If this is specifically for Linux cases and it sounds like we don't have control over the toolbar colours I think it's safest to have the boarder for Linux for accessibility.

Thanks, I'll then resolve as "Won't Fix"