Closed Bug 1701184 Opened 3 years ago Closed 10 months ago

Dark theme Preferences - no contrast between buttons and rest of the selected row in the container settings after clicking a button

Categories

(Firefox :: Settings UI, defect, P5)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox89 --- affected

People

(Reporter: cfogel, Assigned: sdk)

Details

Attachments

(1 file)

Attached image 228888888888689.gif

Affected versions

  • 88.0a1(2021-03-25);

Affected platforms

  • Windows 10, macOS 10.15;

Steps to reproduce

  1. OS / Firefox set on dark theme;
  2. Access about:preferences#containers
  3. Click on any container section;
  4. ALT+TAB to select another application;
  5. Click inside Firefox again on any of Preferences/Remove button(s);

Expected result / Enhancement suggestion

  • button can be distinguished from the focus highlight;

Actual result

  • button and highlights for this section have to close colors;

Regression range

  • not a regression, initial implementation was as this;
  • First bad: 2019-05-30;
  • Last good: 2019-05-29
  • Pushlog: URL

Additional notes

  • set S4 since it's limited use;
  • attached recording to best illustrate the issue.
Has STR: --- → yes
Priority: -- → P5
Summary: Dark theme| Preferences - Container adjust colors on section highlight / buttons to improve visibility → Dark theme Preferences - no contrast between buttons and rest of the selected row in the container settings after clicking a button
Assignee: nobody → contact

I can't reproduce it with the new Proton design (tested in Fx110 both Windows 10 and Linux). The focus hightlight is the same (blueish) wether the window is focused or not. :cfogel can you confirm on your end?

Flags: needinfo?(cristian.fogel)

Looking at it with 116.0a1 (2023-06-22);
color scheme better handles this; improved visibility even after ALT+TAB.

We can indeed close it down.

Status: NEW → RESOLVED
Closed: 10 months ago
Flags: needinfo?(cristian.fogel)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: