[Proton] Too many separators in Page context menu
Categories
(Firefox :: Menus, defect, P2)
Tracking
()
People
(Reporter: bmaris, Assigned: mkohler)
References
(Blocks 2 open bugs)
Details
(Keywords: helpwanted, Whiteboard: [proton-context-menus] [priority:2a])
Attachments
(3 files)
Actual context
Affected versions
- Firefox 88.0b2
- Latest Nightly 89.0a1
Affected platforms
- Windows 10 64bit
- macOS 10.15
- Ubuntu 18.04
Steps to reproduce
- Start Firefox
- Visit a random page
- Right click inside the page to have Page context menu
Expected result
- Per spec there are only 3 separators in Page context menu:
Actual result
- There are 5 separators in Page context menu
Regression range
- Not a regression since this is a design change.
Additional notes
- Not sure if there is already a bug logged for this, I for one did not saw one.
Suggested severity
- I don't think this is of a high severity, I would mark it as S3.
|
||
Updated•3 years ago
|
|
Reporter | |
Comment 1•3 years ago
|
||
|
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Updated•3 years ago
|
|
||
Comment 2•3 years ago
|
||
Setting helpwanted; This probably just means dropping some of the separators in browser-context.inc that surround "send page to device", and then the tedious work of updating the context menu mochitests for the change in expectations.
Note that the screenshots here assume you're signed in to fxa. Without being signed in, there is a similar problem in that there are 4 separators, the excess one being between "save page as" and "select all".
|
||
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f30d84849972 Remove excessive separators in Page context menu r=jaws
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
|
|
Reporter | |
Comment 6•3 years ago
|
||
Verified that this is fixed in latest Nightly 89.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04), the number and location of the separator matches the proposed design.
Description
•