Implement "WebDriver:GetElementShadowRoot" command
Categories
(Remote Protocol :: Marionette, task, P3)
Tracking
(firefox96 fixed)
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: whimboo, Assigned: david.burns)
References
(Blocks 3 open bugs, )
Details
Attachments
(1 file, 1 obsolete file)
This bug will be used to implement the given command in Marionette. Details in the spec can be found here:
https://w3c.github.io/webdriver/#get-element-shadow-root
Beside the command it also needs implementations for the element reference type, and the appropriate Shadow DOM related errors.
It would be great to get some basic tests for the Marionette client that just ensure the command is working. Once bug 1700093 is done we will have detailed tests in the webdriver spec suite.
|
Assignee | |
Comment 1•3 years ago
|
||
This adds the features as described in
https://w3c.github.io/webdriver/#get-element-shadow-root
Depends on D110938
|
||
Updated•3 years ago
|
|
Reporter | |
Comment 2•3 years ago
|
||
Hi David, I wanted to follow-up with you regarding this bug. Could you maybe give an overview what's left to do? Anything that is specifically blocking you, and you need help with? Thanks a lot.
|
|
Assignee | |
Comment 3•3 years ago
|
||
:whimboo
This is nearly done. I haven't had chance to debug why it fails with geckodriver.
Could you have a look and see what I have done wrong, I expect it's something really trivial (I hope)
|
|
Reporter | |
Comment 4•3 years ago
|
||
Sorry for the delay. I was off for a while, and then had a huge backlog. But finally I had a look, and replied on the Phabricator revision itself.
|
|
||
Updated•3 years ago
|
|
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 5•3 years ago
|
||
Hi David, I wanted to check if you would be able to continue on this patch so that we can finish it off. If not please let us know. Thanks!
|
|
Assignee | |
Comment 6•3 years ago
|
||
This adds the features as described in
https://w3c.github.io/webdriver/#get-element-shadow-root
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 7•2 years ago
|
||
this is done and now waiting for review
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b281ca3301b Add Get Shadow Root to Marionette. r=webdriver-reviewers,jgraham,whimboo
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Updated•2 years ago
|
|
||
Updated•1 year ago
|
|
|
Reporter | |
Comment 10•1 year ago
•
|
||
As I've noticed today when trying to get a shadow root via the Selenium Python bindings there is a strict assertion still set for Firefox which will not allow users to actually get the shadow root. I've created a PR to get this removed.
Description
•