Closed Bug 1700064 Opened 3 years ago Closed 3 years ago

Double-tap to zoom is available inside pdf viewer

Categories

(Core :: Panning and Zooming, defect)

Firefox 88
All
macOS
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: emilghitta, Assigned: tnikkel)

References

Details

Attachments

(1 file)

Affected versions

  • Firefox 88.0a1 (BuildId:20210321213736)

Affected platforms

  • macOS 10.14
  • macOS 11.1

Unaffected platforms

  • Windows 10 64bit
  • Ubuntu 20.04

Steps to reproduce

  1. Launch Firefox.
  2. Access the following link
  3. Double-tap to zoom inside the pdf viewer.

Expected result

  • As per the Test Plan document, the double-tap to zoom functionality should not be available inside the pdf viewer (RATO-10)

Actual result

  • The double-tap to zoom functionality is available inside the pdf viewer.

Regression Range

  • I don’t think that this is a regression.

Chrome and Safari either disable this or handle it badly. We don't handle it great so disable it.

Although the document principal looks like it can change I think if that happened at minimum the presshell would be recreated, which creates the ZoomConstraintsClient so we shouldn't need to register to be notified if this changes.

The other option would be to implement support for prevent default of double taps and then have modify pdf.js (if it doesn't already prevent default ctrl wheel events).

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94a9dce30b39
Disable double tap to zoom inside pdf.js. r=botond
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

This is verified fixed using Firefox 89.0a1 (BuildId:20210323094659) on macOS 10.14 & 11.1. The double-tap to zoom functionality is no longer available inside print preview.

Status: RESOLVED → VERIFIED

The double-tap to zoom feature is disabled by default in 88 beta builds.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: