Closed Bug 1699673 Opened 3 years ago Closed 3 years ago

[Proton] Hover effect for an item inside context menu that has a submenu looks like one large hover rectangle

Categories

(Firefox :: Menus, defect, P3)

Product:
Firefox
Component:
Menus
Version:
Firefox 88
Platform:
All
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: bmaris, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-context-menus])

Attachments

(2 files)

Hover effect dark/light theme
144.41 KB, image/jpeg
Details
Bug 1699673 - update Windows 10 proton context menu border and separator colours per UX feedback, r?jaws
48 bytes, text/x-phabricator-request
Details | Review

Affected versions

Affected platforms

  • Windows 10

Steps to reproduce

  1. Start Firefox
  2. Right Click somewhere in the tab bar
  3. Hover over Bookmark Toolbar
  4. Hover over Always Show inside the Bookmark Toolbar submenu

Expected result

  • Two hover effects could be seen for Bookmark Toolbar and Always Show

Actual result

  • It looks like there is one continuous hover effect for both Bookmark Toolbar and Always Show

Regression range

  • This happened after bug 1699427 was fixed. Not sure if this is a regression since it could be the intended behavior. Also before 1699427 was fixed, the Submenu was not glued to the menu so If this turns up to be a bug it will not be a regression.

Additional notes

  • Not sure if this is the intended hover effect for context menus, but IMHO it does not look that great, I think there should be a separator between the two hover effects since they are from different menus.

Suggested severity

  • If this is not the intended behavior I would say this should be an S3 severity but should have high priority since it will be very visible to the users.
Flags: needinfo?(gijskruitbosch+bugs)
Blocks: 1692408
Has Regression Range: --- → irrelevant
Has STR: --- → yes

This is a question for UX. AIUI the hover colours and borders etc. are per spec, and this effect is a logical consequence of the spec - though that doesn't necessarily mean it's intentional. Perhaps the colours of the border could/should be tweaked such that there is a visual separation between the two, or perhaps we are OK with this state. Amy?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(amlee)
Priority: -- → P5

Hi,

Can you please change the border/separators colour to be our secondary "pressed state" colour (see below)? This only applies to Windows context menus.

Light theme #CFCFD8
Dark theme #5B5B66

Thanks

Flags: needinfo?(amlee)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: P5 → P1
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c318706ad746
update Windows 10 proton context menu border and separator colours per UX feedback, r=jaws

https://hg.mozilla.org/mozilla-central/rev/c318706ad746

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Priority: P1 → P3

Verified that using latest Nightly 89.0a1 in Windows 10 that there is now a way to separate the hover effect from menu and submenu.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: