Closed
Bug 1699134
Opened 3 years ago
Closed 3 years ago
[Proton] Submenu icons for disabled options is not greyed out
Categories
(Firefox :: Menus, defect)
Tracking
()
VERIFIED
FIXED
88 Branch
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox86 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | --- | verified |
People
(Reporter: bmaris, Assigned: ntim)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [proton-context-menus])
Attachments
(2 files)
Affected versions
- Latest Nightly 88.0a1
Affected platforms
- Windows 10 64bit
Unaffected platforms
- macOS 10.15
- Ubuntu 18.04
Steps to reproduce
- Start Firefox
- Open a new blank tab
- Right click on the new tab
Expected result
- Send Tab to Device option is disabled (greyed out) and so is the submenu
>
symbol.
Actual result
- Send Tab to Device option is disabled but the submenu
>
symbol is not greyed out. Same for Send Page to Device.
Regression range
- First bad: 6fbbdd2195e123a047c3c859014814ee0ebcab51
- Last good: dceeac349713f185c751524a940cfc1a40e70a5e
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dceeac349713f185c751524a940cfc1a40e70a5e&tochange=6fbbdd2195e123a047c3c859014814ee0ebcab51
- Potential regressor: Bug 1692082 - fix spacing, icons and colours for checkmarks and arrows in Windows 10 menus
Additional notes
- Screenshot showing the issue is attached.
- Items from Menu Bar have the same issue.
Suggested severity
- I would suggest having S3 severity for this bug, it is a noticeable bug but I don't think it's major enough to have it to S2.
Reporter | ||
Updated•3 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
Whiteboard: [proton-context-menus]
Assignee | ||
Comment 1•3 years ago
|
||
--menu-icon-color should be removed and fill: currentColor
+ fill-opacity
should be used instead. That would fix the issue in this bug.
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Updated•3 years ago
|
Attachment #9209989 -
Attachment description: Bug 1699134 - Remove --menu-icon-color in favor of currentColor & fill-opacity. r=jaws,dao → Bug 1699134 - Remove --menu-icon-color in favor of currentColor & fill-opacity.
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ed1f8ac0d787 Remove --menu-icon-color in favor of currentColor & fill-opacity. r=Gijs
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-619
Comment 4•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Reporter | ||
Comment 5•3 years ago
|
||
Verified that this is fixed now in latest Nightly from Today.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•