Preparation for selectAudioOutput() boilerplate
Categories
(Core :: WebRTC: Audio/Video, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(8 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1698238 +++
Things for bug 1698238 that land in Firefox 88.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
|
Assignee | |
Comment 4•3 years ago
|
||
|
|
Assignee | |
Comment 5•3 years ago
|
||
MozPromise can be rejected from any thread.
"Do after the above runs, as it checks active window list" was obsolete as of
https://hg.mozilla.org/mozilla-central/rev/99426a6a77bf8ddfb334ed052eb18e2a9bc48122#l3.223
|
|
Assignee | |
Comment 6•3 years ago
|
||
Denied() is called only from Observe(), which is main thread only.
The comment "Should happen after error runs for consistency, but may not
matter" was obsolete as of
https://hg.mozilla.org/mozilla-central/rev/46c936ce7efed56027d7770690f94ee31f415d7a#l3.634
|
|
Assignee | |
Comment 7•3 years ago
|
||
There is a change in behavior that the SourceListener::Stop() is now run off a
queued event, but timing is not urgent.
|
|
Assignee | |
Comment 8•3 years ago
|
||
MozPromiseHolder stores only a single pointer and so there is no advantage to
having an allocation and additional pointer indirection.
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/033748643968 set media.setsinkid.enabled for all audio-output wpts r=jib https://hg.mozilla.org/integration/autoland/rev/fb5562295c18 add webidl for selectAudioOutput behind media.setsinkid.enabled r=emilio https://hg.mozilla.org/integration/autoland/rev/573a65bf2f5c Remove unused GetUserMediaTask::SetConstraints() r=pehrsons https://hg.mozilla.org/integration/autoland/rev/906f8f4267a2 reject MozPromise immediately in GetUserMediaTask::Fail() r=pehrsons https://hg.mozilla.org/integration/autoland/rev/076b63e4a243 Remove unreached off-main-thread GetUserMediaTask::Denied() path r=pehrsons https://hg.mozilla.org/integration/autoland/rev/fd23665cf805 use Fail() for GetUserMediaTask::Denied() r=pehrsons https://hg.mozilla.org/integration/autoland/rev/2f62527574e7 Simplify some MozPromiseHolder constructions r=pehrsons https://hg.mozilla.org/integration/autoland/rev/7d53e23787ce Add helper methods to manage incomplete GetUserMediaTasks r=pehrsons
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/033748643968
https://hg.mozilla.org/mozilla-central/rev/fb5562295c18
https://hg.mozilla.org/mozilla-central/rev/573a65bf2f5c
https://hg.mozilla.org/mozilla-central/rev/906f8f4267a2
https://hg.mozilla.org/mozilla-central/rev/076b63e4a243
https://hg.mozilla.org/mozilla-central/rev/fd23665cf805
https://hg.mozilla.org/mozilla-central/rev/2f62527574e7
https://hg.mozilla.org/mozilla-central/rev/7d53e23787ce
Description
•