Closed Bug 1696645 Opened 3 years ago Closed 3 years ago

Preferences - Container buttons in settings view are expanding in height to fill in available area-height

Categories

(Firefox :: Settings UI, defect, P3)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox86 --- wontfix
firefox87 --- wontfix
firefox88 --- verified

People

(Reporter: cfogel, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Affected versions

  • 88.0a1(2021-03-03)

Affected platforms

  • Windows 10, macOS 10.13

Steps to reproduce

  1. Launch Firefox access about:preferences#containers
  2. Add or edit a container and input a really long string with spacing in it;
  3. Scroll the Container tabs section;

Expected result

  • buttons keep size-height;

Actual result

  • button height spans across whole available area;

Regression range

  • not a regression;

Additional notes

  • attached screenshot to best illustrate the issue.
Has STR: --- → yes
Priority: -- → P3
Hardware: Unspecified → Desktop

Wrapping text can mean the container name takes up more vertical space.
The buttons should keep their ideal spacing instead of stretching vertically.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Regressed by: 1368957
Has Regression Range: --- → yes
Blocks: 1438571
See Also: 1438571
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/361969553e52
fix height of buttons in container settings rows r=preferences-reviewers,desktop-theme-reviewers,ntim
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Verified with 89.0a1 (2021-03-25)

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: