Affected versions

• 88.0a1(2021-03-03), 87.0b5;

Affected platforms

• Windows 10

Steps to reproduce

1. OS set to dark theme;
2. Launch Firefox, access the Customize page and add the profiler to the toolbar;
3. Click on the Profiler > button to reach to the Settings panel;
4. Observe and click inside the dropdown picker;

Expected result

• theme setup makes text readable;

Actual result

• dark grey background with black color text, makes initial option hard to read;

Regression range

• First bad: 2020-02-16
• Last good: 2020-02-15
• Pushlog: URL
• Potential regressor: bug 1692982

Additional notes

• attached screenshot with the issue;
• affecting all 3 Firefox default themes.

This is also happening when Firefox itself is set to a dark mode using the Customize panel, which makes it possible to test on other OSes too.

I think a quick fix would be to add !important on the dark mode color in [1].
Or remove !important in [2]. I don't really understand why it's needed, but there may be cross-OS issues I'm not aware of.

[1] https://searchfox.org/mozilla-central/rev/bff70a63cff89284426d82ded6469ed708ef68b7/browser/themes/shared/customizableui/panelUI.inc.css#2543-2548
[2] https://searchfox.org/mozilla-central/rev/bff70a63cff89284426d82ded6469ed708ef68b7/browser/themes/shared/customizableui/panelUI.inc.css#2533

Hey Greg, by chance, do you remember why you used !important in [2] above?

It's a shame I didn't document my use of that there. I don't remember, but I'm guessing it was bypassing a built-in rule. I would feel free to change the importance, as this needs to be cross-OS tested anyway. These rules have proven a bit tricky to get correct.

Comment on attachment 9208065 [details]
Bug 1696611 - Remove !important for the CSS property "color" for the Firefox Profiler preset selection box

Revision D107812 was moved to bug 1697478. Setting attachment 9208065 [details] to obsolete.

https://hg.mozilla.org/mozilla-central/rev/5dbc5dd905ca

Comment on attachment 9208065 [details]
Bug 1696611 - Remove !important for the CSS property "color" for the Firefox Profiler preset selection box

Beta/Release Uplift Approval Request

• User impact if declined: Dark mode isn't usable enough for the profiler button.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): They are very simple CSS changes.
  (please look at the changes in HG rather than the diff in phabricator that I changed by mistake).
• String changes made/needed: none

Comment on attachment 9208065 [details]
Bug 1696611 - Remove !important for the CSS property "color" for the Firefox Profiler preset selection box

I'd rather let this ride the trains at this stage in the 87 cycle.