Open Bug 1696599 Opened 3 years ago Updated 2 years ago

Profiler - Settings picker not centered in More Tools overflow menu

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

All
Windows
defect

Tracking

(firefox-esr78 wontfix, firefox87 wontfix, firefox88 wontfix, firefox89 wontfix, firefox90 fix-optional)

Tracking Status
firefox-esr78 --- wontfix
firefox87 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- fix-optional

People

(Reporter: cfogel, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image profilersss.gif

Affected versions

  • 88.0a1(2021-03-03), 87.0b5

Affected platforms

  • Windows 10

Steps to reproduce

  1. Launch Firefox, access the Customize page and add the Profiler tool to the overflow;
  2. Click on the overflow button;
  3. Click on the Profiler > to expand the settings section;
  4. Observe then click the Settings picker dropdown button;

Expected result

  • button is centered;

Actual result

  • button is centered only after the click;
  • max-length values might need revision as well to best fit in the section;

Regression range

  • not a regression, issue was visible with initial implementation;
  • First bad: 2020-03-25;
  • Last good: 2020-03-24;
  • Pushlog: URL
  • Potential regressor: bug 1572786;

Additional notes

  • macOS 10.15 appears to not be affected;
  • issue reproducible with OS recommended and 800x600 resolution;
  • attached recording with the issue.
Has STR: --- → yes
Keywords: regression

Moving component given bug 1572786 implemented this.

Component: Toolbars and Customization → Performance Tools (Profiler/Timeline)
Product: Firefox → DevTools
Priority: -- → P3

The problem might be around this code: https://searchfox.org/mozilla-central/rev/9043e515e9608cc55b252a40cb2dfb6f767bcffd/devtools/client/performance-new/popup/panel.jsm.js#248-267

It's not 100% clear to me if we still need this. I think this is because of the collapsible information at the top of the panel, but I'm not sure.

Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: