Audio file doesn’t restart if skipping to the end of the seekbar while in loop mode
Categories
(Core :: Audio/Video: Playback, defect, P3)
Tracking
()
People
(Reporter: emilghitta, Assigned: alwu)
References
(Blocks 1 open bug, Regression, )
Details
(Keywords: regression)
Attachments
(5 files)
audioMediaLoop.gif
Affected versions
- Firefox 86.0 (BuildId:20210222142601)
- Firefox 87.0b2 (BuildId:20210223185702)
- Firefox 88.0a1 (BuildId:20210223230332)
- Firefox 78.8.0esr (BuildId:20210217034806)
Affected platforms
- Windows 10 64bit
- Ubuntu 20.04 64bit
- macOS 10.14
Steps to reproduce
- Launch Firefox.
- Access the following link.
- Right click on the seekbar.
- Click on the “loop” option from the context menu.
- Click on the seekbar to skip to the end of the audio file.
Expected result
- The audio is restarted successfully since the loop mode is active.
Actual result
- The audio is not restarted. It seems that sometimes it remains frozen at 2:55 or at 0:00.
Regression Range
- This seems to be an old regression:
- Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8b245cc1086f912f84b54a6af13f015404af8e14&tochange=8264fe75578f62fa4f14d48ec8ca86d109e8ddf5
- Possible Regressor: Bug 1505972
Notes
- For further information regarding this issue please observe the attached screencast.
- Please note that it is possible that you may have to refresh the page and redo steps 3 - 5 a couple of times (if you can't reproduce it from the first try).
|
Reporter | |
Comment 1•3 years ago
•
|
||
Hi Alastor!
I tried searching for the exact regressor but since the regression is too old I keep on hitting 4:50.04 INFO: There are no build artifacts for these changesets (they are probably too old).
Taking a look at the generated pushlog it seems that you have previously worked on the loop functionality in Bug 1505972.
Can you please take a look? And sorry in advance if I pointed on the wrong regressor bug.
Thank you!
|
Assignee | |
Comment 2•3 years ago
|
||
That is possible, will take a look later.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
I'm working on this today, and will submit my patches later after I finish testing them.
|
|
Assignee | |
Comment 4•3 years ago
|
||
|
|
Assignee | |
Comment 5•3 years ago
|
||
When audio has reaches to EOS, we will call its Finish() to make it ended, and the audio queue can be reopen again by pushing new data.
Before we reopen the audio queue again, we should not start playback. Otherwise, AudioSinkWrapper would resolve end promise immediately [1]. The concept of reopening audio queue doesn't exist for other classes that access to the audio queue.
Therefore, we should set mIsPrerolling=true in order to wait for new data that can reopen the queue again.
Depends on D110878
|
|
Assignee | |
Comment 6•3 years ago
|
||
Depends on D110879
|
|
Assignee | |
Comment 7•3 years ago
|
||
At the time I worked on this state, it was only used for audio. There were some problems blocking the implementation for video, but the comment wasn't updated.
So we should correct the comment to make it reflect the real situation.
Depends on D110880
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/288a653bc445 part1 : add debug log for media decoder. r=bryce https://hg.mozilla.org/integration/autoland/rev/1ffca5142b37 part2 : should preroll data to reopen the audio queue before starting the playback. r=bryce https://hg.mozilla.org/integration/autoland/rev/e11fe857b496 part3 : add wpt test. r=bryce https://hg.mozilla.org/integration/autoland/rev/6d1ba29557a8 part4 : correct the comment for LoopingDecodingState. r=bryce
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28409 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
|
||
Comment 11•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/288a653bc445
https://hg.mozilla.org/mozilla-central/rev/1ffca5142b37
https://hg.mozilla.org/mozilla-central/rev/e11fe857b496
https://hg.mozilla.org/mozilla-central/rev/6d1ba29557a8
|
||
Updated•3 years ago
|
Description
•