This will help us understand the extent of the impact.

Comment on attachment 9204294 [details]
data-review.md

Documentation needs to be manually updated in https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/environment.html#userprefs

Comment on attachment 9204294 [details]
data-review.md

I've updated the patch to update the documentation, if that's what you meant?

Comment on attachment 9204294 [details]
data-review.md

PRELIMINARY NOTES:

Yes, the documentation needs to be updated. In addition, your answer to Q6 could be updated to link to https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/environment.html

( But we can leave that alone as two round-trips are enough, and I've mentioned it here. )

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Tom Ritter is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

Result: datareview+

https://hg.mozilla.org/mozilla-central/rev/bc83d50bcfc9

I'm seeing data for SCALARS_PRIVACY.FEATURE.FIRST_PARTY_ISOLATION_ENABLED but nothing for RFP

Comment on attachment 9204292 [details]
Bug 1693861: Record telemetry for popular but unsupported privacy prefs r?chutten

Beta/Release Uplift Approval Request

• User impact if declined: We will need to wait an additional cycle to get data on Release users with Telemetry, delaying any potential user improvement behavior we could develop.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple telemetry preference collection fitting into existing infrastructure.
• String changes made/needed:

Comment on attachment 9204292 [details]
Bug 1693861: Record telemetry for popular but unsupported privacy prefs r?chutten

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: It would be interesting to be able to compare the ESR and Release populations. (To the extent possible because we think a lot of ESR users have Telemetry disabled.)
• User impact if declined: We won't be able to make that comparison.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple telemetry pref collection, fitting into existing infrastructure.
• String or UUID changes made by this patch:

Comment on attachment 9204292 [details]
Bug 1693861: Record telemetry for popular but unsupported privacy prefs r?chutten

approved for 87.0b8

https://hg.mozilla.org/releases/mozilla-beta/rev/ef854f20ad12

Comment on attachment 9204292 [details]
Bug 1693861: Record telemetry for popular but unsupported privacy prefs r?chutten

Approved for 78.9esr.

https://hg.mozilla.org/releases/mozilla-esr78/rev/fa9d22975284