Closed Bug 1692984 Opened 3 years ago Closed 3 years ago

Add support for "webSocketUrl” capability to Marionette

Categories

(Remote Protocol :: Marionette, task, P2)

Default
task
Points:
8

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [bidi-m1-mvp])

Attachments

(1 file)

The additional boolean webSocketUrl capability is used to request a WebDriver BiDi websocket: https://w3c.github.io/webdriver-bidi/#establishing

Similar to the moz:debuggerAddress capability it needs to be validated by Marionette, and has make sure to create to return the Websocket URL. When webSocketUrl is set it should be asserted for true.

Returned will be a WebSocket URI:
https://w3c.github.io/webdriver-bidi/#construct-a-websocket-url

James, what actually defines the secure bit of the WebSocket connection? I assume that we should basically use it by default and only fallback if a secure connection cannot be established? I don't see how a client could actually request that.

Flags: needinfo?

Actually Marionette has to handle all that. Geckodriver just passes-through the URL.

James, mind having a look at my question from comment 0? Thanks.

Component: geckodriver → Marionette
Flags: needinfo?(james)
Summary: Add support for "webSocketUrl” capability to geckodriver → Add support for "webSocketUrl” capability to Marionette
Blocks: 1693004

https://w3c.github.io/webdriver-bidi/#start-listening-for-a-websocket-connection is called from the WebDriver New Session Algorithm in https://w3c.github.io/webdriver-bidi/#establishing Basically it's up to you whether the connection is ws:// or wss:// and the client has to deal with either.

Flags: needinfo?(james)
Flags: needinfo?
Blocks: 1693828
No longer blocks: 1691396
Points: --- → 8
Priority: -- → P2

(In reply to James Graham [:jgraham] from comment #2)

Basically it's up to you whether the connection is ws:// or wss:// and the client has to deal with either.

It would be good to know the overhead for secure websockets, but given that HTTPS is that highly promoted (versus HTTP) we should maybe also default to a secure websocket, which wouldn't allow sniffing on the network. If clients cannot handle that we might want to add another capability or preference to fallback to a non-secure websocket.

Depends on: 1693812
Depends on: 1691446
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #9230899 - Attachment description: Bug 1692984 - [marionette] Add support for “webSocketUrl” capability. → WIP: Bug 1692984 - [marionette] Add support for “webSocketUrl” capability.
Attachment #9230899 - Attachment description: WIP: Bug 1692984 - [marionette] Add support for “webSocketUrl” capability. → Bug 1692984 - [marionette] Add support for “webSocketUrl” capability.
Attachment #9230899 - Attachment description: Bug 1692984 - [marionette] Add support for “webSocketUrl” capability. → WIP: Bug 1692984 - [marionette] Add support for “webSocketUrl” capability.
Attachment #9230899 - Attachment description: WIP: Bug 1692984 - [marionette] Add support for “webSocketUrl” capability. → Bug 1692984 - [marionette] Add support for “webSocketUrl” capability.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd61434c223f
[marionette] Add support for “webSocketUrl” capability. r=webdriver-reviewers,jdescottes,jgraham
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Regressions: 1721011
Regressions: 1721012
No longer regressions: 1721011
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: