Closed Bug 1691668 Opened 3 years ago Closed 1 year ago

[macOS] Spreadsheet icons disappear when the page is pinched or scrolled beyond a point

Categories

(Core :: Graphics: WebRender, defect)

Firefox 85
Desktop
macOS
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- wontfix
firefox86 --- wontfix
firefox87 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- wontfix

People

(Reporter: csasca, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Affected versions

  • Firefox 85.0.2
  • Firefox 86.0b7
  • Firefox 87.0a1

Affected platforms

  • macOS 10.15.7 & 11.2

Steps to reproduce

  1. Launch Firefox
  2. Access any Google Spreadsheet
  3. Pinch the page or scroll it

Expected result

  • Some edit/menu icons will disappear after pinching/zooming

Actual result

  • All icons are visible after pinching/zooming

Regression range

  • Will see for a regression

Additional notes

  • The issue can be seen in the following attachment
  • The issue is much more easier to reproduce by pinch.
Has Regression Range: --- → no
Has STR: --- → yes

Looks like those images are draw as background images from an svg sprite sheet. Only reproduces with webrender for me.

./mach mozregression --pref gfx.webrender.all:true apz.allow_zooming:true --profile-persistence clone-first -a "a google spreadsheet"

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=43cc31d4bf1d5fa50c7f90d7f864aada1e570db0&tochange=194ca0c692cd02eb8b3a0387f5d3b999132bf9ae

-> bug 1662062

Hmm, wonder if including the pinch zoom resolution makes some math go funky somewhere?

Flags: needinfo?(tnikkel)
Regressed by: 1662062
Component: Layout: Scrolling and Overflow → Graphics: WebRender
Flags: needinfo?(tnikkel)
Attached file testcase

Pinch zoom a 74px x 6523px svg image is all that's needed to reproduce, we probably exceed a size threshold and don't allow decoding.

Flags: needinfo?(tnikkel)

In a debug build plenty of these in the console

[GFX3-]: Surface size too large (exceeds extent limit)!
[GFX3-]: Surface size too large (exceeds extent limit)!
Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Failed to allocate a surface due to invalid size (DTD) Size(399,35170) (t=6.07237) [GFX1-]: Failed to allocate a surface due to invalid size (DTD) Size(399,35170)
[GFX3-]: Surface size too large (exceeds extent limit)!
[GFX3-]: Surface size too large (exceeds extent limit)!
Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Failed to allocate a surface due to invalid size (DTD) Size(399,35170) (t=6.07237) |[C1][GFX1-]: Failed to allocate a surface due to invalid size (DTD) Size(399,35170) (t=8.92195) [GFX1-]: Failed to allocate a surface due to invalid size (DTD) Size(399,35170)
[GFX3-]: Surface size too large (exceeds extent limit)!
[GFX3-]: Surface size too large (exceeds extent limit)!

QA Whiteboard: [qa-regression-triage]
Has Regression Range: no → yes

Timothy, did you make any progress?

See Also: → 1737891
See Also: → 1773355
See Also: → 1793693
Depends on: 1814878
Flags: needinfo?(tnikkel)

This should be fixed now, can you confirm?

Flags: needinfo?(catalin.sasca)

Yep, cannot reproduce it anymore on macOS 13.3 with Firefox 112.0 and 113.0a1 (2023-04-03). Closing it as WFM. Thank you!

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(catalin.sasca)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: