remove Email field from main process crash reporter
Categories
(Toolkit :: Crash Reporting, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: willkg, Assigned: willkg)
References
Details
Attachments
(1 file)
We're going to stop collecting, processing, and storing Email data from crash reports.
This bug covers removing the Email field from the main process crash reporter.
Assignee | ||
Comment 1•3 years ago
|
||
I just did the content process crash reporter changes. Grabbing this one to do this, too.
Assignee | ||
Comment 2•3 years ago
|
||
There are no automated tests for this, so the testing has to be done manually.
There are three platforms: Linux, Mac, Windows.
For each platform, do the following smoke test:
- start up Firefox with the crash reporter enabled
- go to
about:crashparent
which will immediately crash the main process for Firefox and kick up the crash reporter dialog - verify dialog comes up with the following in this order:
- a check box for "Tell Mozilla ..."
- a button for "Details"
- a text field for "Add a comment..."
- a check box for "Include the address of the page I was on"
- a label for "Your crash report will be submitted ..."
- uncheck "Tell Mozilla ..." check box --> "Details" button, "Add a comment ..." text field, and the "Include the address ..." checkbox are all disabled; "Your crash report will be submitted ..." label disappears
- check "Tell Mozilla ..." check box --> "Details" button, "Add a comment ..." text field, and the "Include the address ..." checkbox are all enabled; "Your crash report will be submitted ..." label appears
- press "Details" button --> shows a dialog with crash annotation data
- type "test report <TIME> <USER> <PLATFORM>" into "Add a comment ..." text field substituting time, user, and platform with appropriate strings so you can find it in Crash Stats web site
- click on Restart Firefox
- wait 5 minutes
- find crash report on Crash Stats using supersearch
If there are other things I should test, let me know.
Assignee | ||
Comment 3•3 years ago
|
||
Gabriele: I'm doing a try build for build-win64/debug
. The most recent one being here:
https://treeherder.mozilla.org/jobs?repo=try&revision=7df94d6d9ed0e80e7b5e2946d87a7daa20b9fc3f
If I download the target.installer.exe
artifact and install Firefox with it, that should get me a Firefox that I can crash.
I start it up and go to about:crashparent
. Firefox crashes immediately, but no crash reporter kicks in. I checked application.ini
and the crash reporter seems like it's enabled. I looked through the crashreporter docs, too.
It feels like either I have a bug in the changes I made or there's something I'm not doing to make sure the crashreporter is running. Any ideas?
Assignee | ||
Comment 4•3 years ago
|
||
I switched from Windows powershell to cmd and now it works fine.
Linux crash report: https://crash-stats.mozilla.org/report/index/2435726a-909c-4727-85e2-e7afe0210222
Windows crash report: https://crash-stats.mozilla.org/report/index/03729ac2-d430-47a7-8b6e-87f750210224
I'll test macOS tomorrow.
Assignee | ||
Comment 5•3 years ago
|
||
We're no longer collecting Email data for crash reports so this removes the
Email field and related bits from the main process crash reporters for Linux,
Mac, and Windows.
For Mac, I didn't remove the email-related fields, but instead hid them. In
order to remove them, I need to use an old xcode ibuilder to edit the .nib
files and we don't have that. Bug #1696164 covers updating the crash reporter
interface files on mac.
Assignee | ||
Comment 6•3 years ago
|
||
I had problems changing the .nib files. The keyedobjects.nib file is in a binary format which I can't edit with the version of xcode and ibuilder that I have. So instead of trying to edit that, I kept the email fields and hid them.
Bug #1696164 covers updating the interface code for the crash reporter client on macOS with a recent xcode.
Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e7f1a11f541 remove email field from main process crash reporter. r=gsvelto
Comment 8•3 years ago
|
||
bugherder |
Description
•