Hide the Page actions overflow (meatball) menu from the address bar
Categories
(Firefox :: Toolbars and Customization, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | verified |
People
(Reporter: mstriemer, Assigned: mak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-address-bar])
Attachments
(1 file)
Since pageAction buttons always be in the address bar we will no longer need to include the Page actions (meatball) menu in the address bar.
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 2•3 years ago
•
|
||
There's code hiding page action buttons, because they're duplicated in the menu, in order to keep the address bar usable in narrow windows: https://searchfox.org/mozilla-central/rev/3ff133d19f87da2ba01ade55d6e7fdf0fc28b08c/browser/base/content/browser.css#764-774
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
•
|
||
There are a few things that are apparently not tracked elsewhere, thus I'm annotating them here. They are potentially feasible in shippable increments and parallelizable, thus feel free to file as follow-ups if you think it's too much to do here.
- the Remove from Address Bar option and the following HR should be removed from the context menu of actions in Proton. Or better, built-in actions should not have a context menu anymore, while extensions should only have Manage Extension and Remove Extension. The same if we implement overflow (see point 2), for actions shown in the menu.
- we are discussing overflow in the Jira Spike, it may be worth supporting some kind of simple overflow behavior, and there I suggested to just hide/show all the actions depending on the window size, as a first step. So basically, if the window (or the urlbar) is smaller than a threshold, hide all the actions and unhide the meatball menu. This should be easy to do with simple CSS. We can keep doing something similar to comment 2.
Comment 4•3 years ago
|
||
Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.
Assignee | ||
Comment 5•3 years ago
|
||
I splitted the context menu thing to bug 1700364, so here we just have to hide the menu and handle the overflow hiding/showing.
Assignee | ||
Comment 6•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/5b0ea1550e11 Hide the Page actions overflow (meatball) menu from the address bar. r=adw
Comment 8•3 years ago
|
||
bugherder |
Comment hidden (advocacy) |
Comment 10•3 years ago
|
||
verified meatball menu not visible on urlbar on windows10 64bit, MacOS 10.15 and Ubuntu 20 64bit using Firefox nightly 90.0a1 and beta 89.0b10
Description
•