Closed Bug 1687614 Opened 3 years ago Closed 3 years ago

About Firefox green checkmark is not centered with the message that follows it

Categories

(Firefox :: General, defect)

Firefox 86
defect

Tracking

()

VERIFIED FIXED
86 Branch
Tracking Status
firefox86 --- verified

People

(Reporter: csasca, Assigned: bigiri)

References

Details

Attachments

(5 files)

Attached image nightly checkmark.png

Affected versions

  • Firefox 86.0a1

Affected platforms

  • Windows 10
  • macOS 10.15.7
  • Ubuntu 20.04

Steps to reproduce

  1. Launch Firefox
  2. Access About Nightly

Expected result

  • The newly added green checkmark is centered with the message following it

Actual result

  • The checkmark is not centered

Regression range

  • This is not a regression, as it was just implemented in Nightly builds

Additional notes

  • The issue can be seen in the attachment
  • There is an added restart sign if an update is downloaded and Firefox prompts the user which is affected too.
Has STR: --- → yes

Not exactly sure if Firefox::General is a good place for the About dialog, but this just looks like a CSS that needs fixing.

Blocks: 1660848
Component: Layout: Positioned → General
Product: Core → Firefox

(In reply to Catalin Sasca, QA [:csasca] from comment #0)

Expected result

  • The newly added green checkmark is centered with the message following it

Checkmark should be centered between 2 lines with no spacing between those lines.
See: https://bug1687213.bmoattachments.org/attachment.cgi?id=9197739

Type: enhancement → defect
Assignee: nobody → bigiri
Attached image Checkmark.png

Proposed change to check mark.

Attached image loadingindicator.png

Change effect on loading indicator.

Attached image restarticon.png

Change effect on start icon.

Changed the alignment for the following icons as they are all part of the same markup:

Check mark: https://bugzilla.mozilla.org/attachment.cgi?id=9198469

Loading indicator: https://bugzilla.mozilla.org/attachment.cgi?id=9198470

Restart: https://bugzilla.mozilla.org/attachment.cgi?id=9198471

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4beeece4d42
Centered check mark icon in About Dialog. r=mconley
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Flags: qe-verify+

I can confirm this issue is fixed, I verified using Firefox 89.0 on Win 8.1 x64 and macOS 11 and Ubuntu 20.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: