Resizing the browser horizontally while in customize mode does not respect the minimum width
Categories
(Firefox :: Toolbars and Customization, defect, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | wontfix |
firefox84 | --- | wontfix |
firefox85 | --- | wontfix |
firefox86 | --- | wontfix |
firefox87 | --- | fix-optional |
People
(Reporter: atrif, Unassigned, NeedInfo)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
6.09 MB,
image/gif
|
Details |
Affected versions
- 86.0a1 (20210117214903)
- 85.0b9 (20210114193053)
- 84.0.2 (20210105180113)
- 78.6.1esr (20210105204613)
Affected platforms
- Windows 10x64
- MacOS 11
- Ubuntu 18.04
Steps to reproduce
- Open Firefox and go to the Customize menu.
- Resize the browser horizontally making it smaller.
Expected result
- Browser is resized as expected respecting the minimum width.
Actual result
- On Windows 10x64 the Minimize, Maximize buttons are cut off: screenshot
- On macOS 11 there is only Back and Forward buttons displayed: screenshot
- On Ubuntu 18.04 the entire browser can be hidden while resizing (see attached screen recording)
Regression range
- Last good revision: caf55914ccddba34d462a1206530d7868b6c4992 (2019-11-09)
- First bad revision: 72c52c0101cfd102b207224646c3007d6872e65c (2019-11-10)
- Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=caf55914ccddba34d462a1206530d7868b6c4992&tochange=72c52c0101cfd102b207224646c3007d6872e65c
Notes
- Attached a screen recording.
- The issue can be reproducible only in customize mode.
Reporter | ||
Updated•3 years ago
|
Comment 1•3 years ago
|
||
This is because the min-width: -moz-fit-content
rule in browser.css applied to :root
stopped having any effect when we changed the root element in bug 1492582 .
This problem was noticed in bug 1610497 in the phabricator comments but not fixed; as far as I can tell the follow-up bug discussed was not filed.
Comment 2•3 years ago
|
||
(In reply to :Gijs (he/him) from comment #1)
This is because the
min-width: -moz-fit-content
rule in browser.css applied to:root
stopped having any effect when we changed the root element in bug 1492582 .This problem was noticed in bug 1610497 in the phabricator comments but not fixed; as far as I can tell the follow-up bug discussed was not filed.
Not overriding the non-customization minimum width of 450px makes the situation better, but at least on Windows 10 it still leads to the overflow panel in customize mode getting clipped. I experimented a bit but couldn't figure out how to change this.
Dão or Brendan, do you perhaps have ideas here?
Comment 3•3 years ago
|
||
For non-xul root elements we're doing a simple lookup on the style min-width. Emilio had a comment on an alternative way to do this awhile back. I'm not sure if addressing that would fix the issue though.
Updated•3 years ago
|
Updated•3 years ago
|
Comment 4•2 years ago
|
||
Bug 1799426 should fix this too.
Reporter | ||
Comment 5•2 years ago
|
||
Confirming that the min-width is now applied inside Customize Menu in Windows 10x64, macOS 12 and Ubuntu 20.04.
Description
•