Closed Bug 1686735 Opened 3 years ago Closed 3 years ago

Themes drop-down menu from about:customize is shaking sometimes when opened

Categories

(Firefox :: Toolbars and Customization, defect)

Desktop
macOS
defect

Tracking

()

VERIFIED FIXED
86 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- wontfix
firefox85 --- wontfix
firefox86 --- verified

People

(Reporter: atrif, Assigned: mstange)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Affected versions

  • 86.0a1 (20210113213439)
  • 85.0b8 (20210112185508)
  • 84.0.2 (20210105180113)

Affected platforms

  • Mac Mini M1 11.1
  • MacBook Pro 11.1

Steps to reproduce

  1. Open Firefox and go to the Customize menu.
  2. Click on the page anywhere and select the Themes drop-down menu.

Expected result

  • Themes drop-down menu is opened as expected.

Actual result

  • The drop-down menu is sometimes shaking.

Regression range

  • I will search for one ASAP if there is one.

Notes

  • Attached a screen recording.
  • The issue may be intermittent. After the Themes dropdown menu is opened focus the page and select the drop-down again. If not reproduced, repeat the steps.
Has Regression Range: --- → no
Has STR: --- → yes

Can you use mozregression to find when this started happening?

Flags: needinfo?(alexandru.trif)
QA Whiteboard: [qa-regression-triage]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)

Can you use mozregression to find when this started happening?

Last good revision: c9608b9b20ea749426c8f3fad7b9db81cf16125f
First bad revision: a6726f60328a0d06942b77138e4a0c1e7b3b3025
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c9608b9b20ea749426c8f3fad7b9db81cf16125f&tochange=a6726f60328a0d06942b77138e4a0c1e7b3b3025

Mozregression points out bug 1672091.

Has Regression Range: no → yes
Flags: needinfo?(alexandru.trif)

Markus, can you look at this? It looks like it is a regression from your work.

Flags: needinfo?(mstange.moz)

It looks like we still have a transform animation during the opening of this panel. I was intending to turn off both the opacity and the transform animation. I'll fix the oversight.

The style system should be telling the widget about its new window transform before the widget is opened. It doesn't seem to be doing that consistently. So that might also be worth investigating. In the past, this shaking was probably happening already, but it was hidden by the opacity fade-in animation (which my patch removed).

Assignee: nobody → mstange.moz
Status: NEW → ASSIGNED
Flags: needinfo?(mstange.moz)
Regressed by: 1672091

This was an oversight in the original patch. I forgot to include the "bottom"
variant in the @media scope.

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/559529d56050
On macOS Big Sur, also disable the slide-in-from-bottom animation for panels. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

The patch landed in nightly and beta is affected.
:mstange, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(mstange.moz)

Verified fixed on Mac Mini M1 macOS 11.1 with Firefox 86.0b3(20210128185743). The themes dropdown menu is no longer shaking if opened multiple times.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: