Affected versions

• 84.0.2 (20210105180113)
• 85.0b6 (20210107185759)
• 86.0a1 (20210108094818)

Affected platforms

• Windows 10x64

Preconditions

• High contrast enabled

Steps to reproduce

1. Open Firefox and http://foersom.com/net/HowTo/data/OoPdfFormExample.pdf.
2. Observe the elements from the top PDF bar.

Expected result

• All elements are displayed as expected.

Actual result

• Some elements from the bar are not visible.

Regression range

• I will search for one ASAP.

Notes

• Attached a screenshot.

Hello! Attaching the regression range results made on Windows 10x64.
Last good revision: 89bbbe5e6369e1ce2b75ddf75cd201782ce362b2
2:55.59 INFO: First bad revision: ed4b5a56979c8df2050dabf933e6e94fa93163c6
2:55.59 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=89bbbe5e6369e1ce2b75ddf75cd201782ce362b2&tochange=ed4b5a56979c8df2050dabf933e6e94fa93163c6
Possible regressor: bug 1660483.

James, is that a serious bug from an accessibility perspective?

Yes, because this makes this totally unusable for a high contrast mode user.

Brendan can you take a look at this? Per comment 3 it's a bad accessibility experience.

I was hoping to get to this, but I have some other ongoing accessibility work in pdf.js. In the mean time, I've opened a bug upstream and asked if the original implementer has some ideas on how to fix it.

At what point should we consider reverting the upstream change until it can reland with this addressed?

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

At what point should we consider reverting the upstream change until it can reland with this addressed?

Unfortunately I really don't think that's even an option at this point in time, given that a fair number of clean-up/improvement patches have landed since the original PR was merged. Hence it's extremely unlikely that you even could back out all of the changes, without a lot of breakage all over the place.

There's also some additional discussion in https://github.com/mozilla/pdf.js/issues/13109

This is going to miss 88 at this point, but it looks like there's an upstream PR going through review now. Hopefully it'll merge in time to make 89 still.

The PDF.js fix landed, but it depends on bug 1704595 to actually work.

Isn't the dependency rather on bug 1659511?

(In reply to Julien Cristau [:jcristau] from comment #10)

Isn't the dependency rather on bug 1659511?

The announcement (https://groups.google.com/g/mozilla.dev.platform/c/zwDaj0JMYjs) mentioned bug 1704595, but yes, it looks like you're right, thanks!

The announcement also mentioned 90, while bug 1659511 landed in 89. What's the plan?

(In reply to Marco Castelluccio [:marco] from comment #11)

(In reply to Julien Cristau [:jcristau] from comment #10)

Isn't the dependency rather on bug 1659511?

The announcement (https://groups.google.com/g/mozilla.dev.platform/c/zwDaj0JMYjs) mentioned bug 1704595, but yes, it looks like you're right, thanks!

The announcement also mentioned 90, while bug 1659511 landed in 89. What's the plan?

Hi! yeah I saw this patch and wanted to make sure we got the fix in, so it'll be in 89 😀

:atrif, could you verify this is fixed in 89?

(In reply to Marco Castelluccio [:marco] from comment #13)

:atrif, could you verify this is fixed in 89?

Yup I can confirm that the elements are now visible using High Contrast and str from comment 0 on Windows 10x64 with Firefox 89.0b5 (20210427185821).