Support full <image> syntax in list-style-image as per spec.
Categories
(Core :: Layout: Generated Content, Lists, and Counters, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
()
Details
(Keywords: dev-doc-complete)
Attachments
(6 files, 1 obsolete file)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
And simplify nsBulletFrame while at it.
|
Assignee | |
Comment 1•3 years ago
|
||
This allows supporting image-set(), etc, and simplifies the bullet frame
code significantly, too thanks to two changes:
-
Instead of manually managing the image request, use the CSS image
loader, with theREQUEST_REQUIRES_REFLOWflag, to handle image
loads correctly. This didn't exist when this code was initially
implemented, but we can nicely use it now. -
Instead of re-implementing another WebRender command-builder thing,
we can just reuse the nsImageRenderer code.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47c73e5e08a4 Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin
|
||
Comment 4•3 years ago
|
||
Backed out changeset 47c73e5e08a4 (bug 1685078) for multiple failures related to CSS. CLOSED TREE
Logs:
https://treeherder.mozilla.org/logviewer?job_id=326045577&repo=autoland&lineNumber=3099
https://treeherder.mozilla.org/logviewer?job_id=326045594&repo=autoland&lineNumber=4220
https://treeherder.mozilla.org/logviewer?job_id=326045573&repo=autoland&lineNumber=3039
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=47c73e5e08a49504a7200236010c01ea2a2a6fdb
Backout:
https://hg.mozilla.org/integration/autoland/rev/762cc086cd05a231dbeecad8e80dd6c524838ebc
|
|
Assignee | |
Comment 5•3 years ago
|
||
The current test relies on the explicit decoding that we start
triggering unconditionally right now, and which my previous patch
removes:
Remove the text so that the animation polling stuff detects when the
image loads (otherwise it sees a non-blank paint and starts thinking
that stuff is loaded, taking the reference snapshot too early).
Depends on D100774
|
|
Assignee | |
Comment 6•3 years ago
|
||
For bullets we don't want to start blocking onload. It shouldn't matter
anyhow but it's simpler and easier not to change behavior.
While at it avoid some expensive includes in ImageLoader.h
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 7•3 years ago
|
||
|
|
Assignee | |
Comment 8•3 years ago
|
||
Depends on D101069
|
|
Assignee | |
Comment 9•3 years ago
|
||
These will make the following patch clearer.
Depends on D101070
|
|
Assignee | |
Comment 10•3 years ago
|
||
Without blocking onload (which preserves behavior before this patch
series) or requiring a decode for stuff like invisible bullets.
Depends on D101071
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 11•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66d167aa16ea Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin https://hg.mozilla.org/integration/autoland/rev/0da6fc5419b3 Fix test_bullet_animation.html. r=tnikkel https://hg.mozilla.org/integration/autoland/rev/9084c962424d Remove some useless includes from ImageLoader.h. r=TYLin https://hg.mozilla.org/integration/autoland/rev/eff6aadf75c0 Use enum classes and more explicit names for ImageLoader flags. r=TYLin https://hg.mozilla.org/integration/autoland/rev/277a1d56fccd Refactor some ImageLoader code for legibility / code reuse. r=TYLin https://hg.mozilla.org/integration/autoland/rev/04b98b03122f Add a flag to reflow when the size is available, and use it for bullets. r=TYLin
|
|
||
Comment 12•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/1771307a8438 Don't return incomplete draw result for errored images.
|
|
||
Comment 13•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/329ab5768e51 Correctly keep sync-decoding images.
|
|
Assignee | |
Comment 14•3 years ago
|
||
(In reply to Pulsebot from comment #13)
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/329ab5768e51
Correctly keep sync-decoding images.
Jeff, mind sanity-checking this commit? It's basically ensuring we pass the right flags to nsImageRenderer, which prevents intermittent reftest failures that the sheriffs pinged me about. Should be pretty straight-forward, but ended up touching a bit more code than I initially thought so probably deserves another look.
|
|
||
Comment 16•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/645a4d6461ca More explicitly fall back for broken images, as sync decoding will happily paint blank in that case.
|
||
Comment 17•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/66d167aa16ea
https://hg.mozilla.org/mozilla-central/rev/0da6fc5419b3
https://hg.mozilla.org/mozilla-central/rev/9084c962424d
https://hg.mozilla.org/mozilla-central/rev/eff6aadf75c0
https://hg.mozilla.org/mozilla-central/rev/277a1d56fccd
https://hg.mozilla.org/mozilla-central/rev/04b98b03122f
https://hg.mozilla.org/mozilla-central/rev/1771307a8438
https://hg.mozilla.org/mozilla-central/rev/329ab5768e51
https://hg.mozilla.org/mozilla-central/rev/645a4d6461ca
|
||
Comment 19•3 years ago
|
||
Added to release note, docs updated with a non URL example, and a note added to BCD.
Description
•