NewTab page - center the action with the close button inside the onboarding message
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
People
(Reporter: cfogel, Assigned: emcminn)
Details
Attachments
(2 files)
imgpsh_fullsize_anim.png
Affected versions
- 85.0b4, 86.0a1(2020-12-22), 84.0.1;
Affected platforms
- macOS 10.15, Windows 10
Steps to reproduce
browser.newtabpage.activity-stream.asrouter.devtoolsEnabled - set on true
- Launch Firefox, access about:newtab#asrouter trigger any message on the NewTab page (ex: NEWSLETTER_TEST_SCENE1_SECTION_TITLE_ICON); or open NewTabs on a fresh profile until such a message is displayed;
- Resize the browser width so it takes up half of screen (or less);
Expected result
- set the vertical center of the action and close button to be the same;
Actual result
- the message, if it takes up more than one row is not centered with the close button;
Regression range
- not a regression;
Additional notes
- set S4 as severity since it's with no impact, main issue being that it appears offset with long messages
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
Hi Aaron, this isn't an urgent request, but Punam and I wanted to check with you.
Since we don't have a consistent way to position the close button relative to the action button due to the way snippets are structured, we figured it would be safer to position the close button in the upper right corner. This will keep the position of the button consistent across all snippets no matter the content, at all screen widths. As long as this is ok from a UX perspective, that's what we'll go with. Thanks!
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Comment 3•3 years ago
|
||
Including Ryan for UI feedback
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 4•3 years ago
|
||
Hi Emily, just catching up on this. So to be clear your suggestion is to move the X close button to the to-right corner of the snippet, so it would be inline with the title "Messages from Firefox" on the left, correct? If so I think that makes sense. thanks! emcminn@mozilla.com
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by emcminn@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f96f66d3690 Move the snippet close button to the upper right corner r=pdahiya
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
|
||
Comment 7•3 years ago
|
||
I don't see a huge need to uplift this to Beta, but it does graft cleanly and seems relatively low-risk if you wanted to nominate it.
|
|
Assignee | |
Comment 8•3 years ago
|
||
(In reply to Ryan Casey from comment #4)
Hi Emily, just catching up on this. So to be clear your suggestion is to move the X close button to the to-right corner of the snippet, so it would be inline with the title "Messages from Firefox" on the left, correct? If so I think that makes sense. thanks! emcminn@mozilla.com
That's what we did! Thanks for your feedback, Ryan :)
|
|
||
Updated•3 years ago
|
|
||
Comment 9•3 years ago
|
||
I have verified that the X "Close" button is correctly displayed in the top-right corner of the snippet on full-screen width, half-screen width, and minimum width using the STR from the description with latest Firefox Nightly 89.0a1 (Build ID: 20210419094740) on Windows 10 x64, macOS 11.2.3, and Ubuntu Linux 20.04.
Description
•