Affected versions

• 86.0a1(20201221093813)
• 85.0b4 (20201220193140)

Affected platforms

• Windows 10x64
• macOS 10.15
• Ubuntu 18.04

Preconditions

• have a saved login and Light OS theme

Steps to reproduce

1. Open about:logins and select a random login.
2. Click on the Mask/ Unmask password button.

Expected result

• Buttons are displayed as expected.

Actual result

• Mask password button is invisible but can be activated.

Regression range

• Last good revision: 3652d2a382005d6c6755405734168ddeca937ff4
• First bad revision: cc1e3921893e658963369bdae4ab264f56474d5e
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3652d2a382005d6c6755405734168ddeca937ff4&tochange=cc1e3921893e658963369bdae4ab264f56474d5e

Notes

• Attached a screen recording.

Suggested Severity: S3

https://hg.mozilla.org/mozilla-central/rev/296c58886005

Comment on attachment 9194864 [details]
Bug 1683678 - Override common.css checkbox colors for the mask password button. r=ntim

Beta/Release Uplift Approval Request

• User impact if declined: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial CSS fix
• String changes made/needed:

Reproduced the initial issue using Firefox 85.0b4, verified that using todays Nightly 86.0a1 this is fixed across platforms (Windows 10, Ubuntu 18.04 and macOS 11).

Comment on attachment 9194864 [details]
Bug 1683678 - Override common.css checkbox colors for the mask password button. r=ntim

css fix, approved for 85.0b5

https://hg.mozilla.org/releases/mozilla-beta/rev/fed69a5dd4c5

Verified fixed using Firefox 85.0b5 (20210105092155) from comment 7 on Windows 10x64, macOS 10.12 and Ubuntu 18.04. Mask password button is correctly displayed on Light OS theme.