Affected versions

• 85.0b2(20201215185920)
• 86.0a1(20201215213427)
• 84.0(20201215213427)

Affected platforms

• Win10x64
• Ubuntu 18.04x64
• macOS 10.15.7

Steps to reproduce

1. Go to about:support.
2. Notice Distribution ID is blank

Expected result

• Distribution ID string is displayed without any issues.

Actual result

• Distribution section is not displayed.

Suggested Severity

• Since this issue occurs for both the UI section of the about:support , as well for the "Copy Raw data to clipboard" and "Copy text to clipboard" options, for all OS's, I would consider this issue an S2.

Regression range

• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=17aa41e3cb7cdff3b94e26e351e29cc8b9bab18a&tochange=47426d145e246fa1924fbda83a8ecb0d25a6f606
• Potential regressor: https://bugzilla.mozilla.org/show_bug.cgi?id=1629946

Additional notes

• This issue occurs for both "Copy Raw data to clipboard" and "Copy text to clipboard" options from the about:support page.

I'm going to set this to S3, because checking the distribution ID of a browser is not "Major functionality", and you can work around the problem by looking in Telemetry: about:telemetry#search=distribution

Are you actually using a distribution / partner build here? If not then it seems like an empty ID might be the expected result?

Just to confirm as patch author, if you're not using a partner/distribution build, it will stay empty. You'd need to have something with a properly set up distribution.ini. Bug 1629946 can't be a regressor as it added that functionality.

Here's a screenshot of it present with a distribution.

Should we do something different when there is no distribution ID?

Do we typically hide things that aren't applicable?

FWIW https://searchfox.org/mozilla-central/source/toolkit/content/aboutSupport.js seems to have a few items that are conditionally hidden/shown.

Hello,

At that time I was using a Nightly build , as seen in the attachment.

This issue still occurs with the same repro steps on 86.0b9(20210211195159) , 87.0a1(20210211213143) and 85.0.2(20210208133944).

In this case, is this the expected behavior?

It is behaving how I implemented it - to shown nothing if the distribution id is not set.

Personally I don't think it matters, it is part of the build data, for most people it won't be set and that potentially helps to clarify it isn't set. I'm open to arguments for hiding it though.

Switching this from a regression/defect to enhancement, and leaving it to others to decide whether this is something we want to do or close as wontfix.

Mark, could you please set a severity and priority or just close this? Sounds like this might be wontfix.

(In reply to Dão Gottwald [::dao] from comment #9)

Mark, could you please set a severity and priority or just close this? Sounds like this might be wontfix.

Enhancements don't need a severity, they can just be "N/A".

That said, unless there's strong feelings here, I think this should be wontfix. It was over 10 months before anyone noticed it, so I think it isn't too much of an issue.