Affected versions

• Fx 84
  Fx 85

Affected platforms

• Win 10 x64
  Win 7 x64
  mac OS 10.15
  Ubuntu 18.04

Steps to reproduce

1. Start Firefox with a fresh profile.
2. Reach about:config and search for browser.toolbars.bookmarks.2h2020 and set it to true.
3. Restart browser with the same profile.
4. Reach about:telemetry and in Scalars search for bookmarks.
5. Add 5 bookmarks to the bookmark toolbar.
6. Reach about:telemetry (refresh the page if already on it) and in Scalars search for bookmarks.
7. Move a bookmark from one position in the toolbar to another position.
8. Repeat step 6.

Expected result

• The value for browser.toolbars.bookmarks.2h2020 should stay the same as in step 6.

Actual result

• The value for browser.toolbars.bookmarks.2h2020 increases every time a bookmark is moved.

Suggested Severity

• S3

Regression range
This is not a regression.

Copy/paste failure in the expected/actual results? I think you meant browser.engagement.bookmarks_toolbar_bookmark_added ?

It also seems that it changes by quite a lot (I'm seeing it going to 6, then 12, then 18), even when drag/dropping only one item... unsure why.

Jared, do you have time to look at this?

In my testing it only adds by 1, but when I open a second window it now increments by 2. I confirmed with Gijs that he had 6 windows open.

Hello,

Yes it was a copy/paste failure. I can confirm the multiple windows issue as well.

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=37a6b8654987d85dc7f5d1db97cd0074143ff013

Log: https://treeherder.mozilla.org/logviewer?job_id=324963611&repo=autoland&lineNumber=6342

Backout: https://hg.mozilla.org/integration/autoland/rev/21cd8c9579d2860d4fc52c2609152692ad0d344b

https://hg.mozilla.org/mozilla-central/rev/036f1d3e590e

Comment on attachment 9193561 [details]
Bug 1682553 - Move bookmarks listeners to PlacesUIUtils so there will only be one listener instead of one per window.

Beta/Release Uplift Approval Request

• User impact if declined: Telemetry counts for bookmarks added to the bookmarks toolbar will be incorrect
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps can be found at https://bugzilla.mozilla.org/show_bug.cgi?id=1665391#c6
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Telemetry-only change
• String changes made/needed: none

Reproduced the issue on Firefox Nightly 85.0a1 (20201201).

Verified the fix on Firefox Nightly 86.0a1 (20201223) on Mac 10.15, Win 10 and Ubuntu 18.04.

Comment on attachment 9193561 [details]
Bug 1682553 - Move bookmarks listeners to PlacesUIUtils so there will only be one listener instead of one per window.

approved for 85.0b5

https://hg.mozilla.org/releases/mozilla-beta/rev/67778009fae7