Closed Bug 1682316 Opened 3 years ago Closed 3 years ago

Print preview paginator is not responsive to browser window shrink

Categories

(Toolkit :: Printing, defect, P2)

Product:
Toolkit
Component:
Printing
Version:
Firefox 85
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox85 --- wontfix
firefox86 --- verified

People

(Reporter: emilghitta, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [print2020_v86] [old-ui-] )

Attachments

(2 files)

ResizePaginator.gif
8.36 MB, image/gif
Details
Bug 1682316 - Hide the print preview pagination nav btns in narrow windows. r?mstriemer!
48 bytes, text/x-phabricator-request
Details | Review
Attached image ResizePaginator.gif —

Affected versions

  • Firefox 85.0a1 (BuildId:20201214091023)

Affected platforms

  • Windows 10 64bit
  • macOS 10.15
  • Ubuntu 20.04 64bit.

Steps to reproduce

  1. Launch Firefox.
  2. Access the following website
  3. Hit Ctrl + P in order to open the print preview.
  4. Resize the browser window.

Expected result

  • The paginator adjusts correctly to the browser window resize.

Actual result

  • The paginator overlaps the preview’s vertical scrollbar and seems to loose it’s background button colors on the edges (more visible on dark mode).

Regression Range

  • This is not a regression.

Notes

  • For further information please observe the attached screencast.
  • [Suggested Severity] I think that S4 fits for this issue.
Has Regression Range: --- → no
Has STR: --- → yes
Summary: Print preview paginator is not responsive on browser window shrink → Print preview paginator is not responsive to browser window shrink

We should fix this for 85.

I think we can hide the buttons when the preview is narrow enough.

Whiteboard: [print2020_v86] [old-ui-] → [print2020_v85] [old-ui-]
Severity: -- → S4
Priority: -- → P2
Assignee: nobody → mstriemer

(Moving bugs to 86, part 1.)

Whiteboard: [print2020_v85] [old-ui-] → [print2020_v86][old-ui-]
Assignee: mstriemer → nobody

(In reply to Mark Striemer [:mstriemer] from comment #1)

I think we can hide the buttons when the preview is narrow enough.

So, at some threshold width drop the home/back/next/end buttons? The reasoning being that at narrower widths where the preview is scaled right down, current-page indication is of more value than the need to navigate around the document (the scrollbar is always there as an alternative.)

I'll try that out and see how it works, and if we might need to stop displaying the toolbar altogether at some widths.

Assignee: nobody → sfoster
Status: NEW → ASSIGNED
See Also: → 1687014
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6945e411e5b6
Hide the print preview pagination nav btns in narrow windows. r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/6945e411e5b6

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

The patch landed in nightly and beta is affected.
:sfoster, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(sfoster)
status-firefox85: affected → wontfix
Flags: needinfo?(sfoster)
Flags: qe-verify+

Moving things to 88, cause we're mostly on Proton these days…

Whiteboard: [print2020_v86][old-ui-] → [print2020_v88] [old-ui-]
Whiteboard: [print2020_v88] [old-ui-] → [print2020_v86] [old-ui-]

This issue is verified fixed using Firefox 86.0b7 (BuildId:20210207185447) and Firefox 87.0a1 (BuildId:20210207214322) on Windows 10 64bit, macOS 10.14 and Ubuntu 20.04 64bit.

Status: RESOLVED → VERIFIED
status-firefox86: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: