Print margin unit should be localized
Categories
(Toolkit :: Printing, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox83 | --- | unaffected |
firefox84 | --- | wontfix |
firefox85 | --- | wontfix |
firefox86 | --- | wontfix |
firefox87 | --- | wontfix |
firefox88 | --- | fixed |
People
(Reporter: alice0775, Assigned: sfoster)
References
Details
(Keywords: parity-chrome, regression, Whiteboard: [print2020_v88] )
Attachments
(2 files)
Margin unit is fixed in "inch". But the Margin unit should be localized.
STR:
Ctrl+P > more settings > Margins > select Custom (inches)
Actual results:
Margin unit is fixed in "inch"
Expected results:
Margin unit should be in "mm" in Ja locale. Firefox83 and Chromium works as expected.
Updated•3 years ago
|
Updated•3 years ago
|
Comment 2•3 years ago
|
||
We've never supported mm so I don't think this is a regression.
Reporter | ||
Comment 3•3 years ago
|
||
(In reply to Mark Striemer [:mstriemer] from comment #2)
We've never supported mm so I don't think this is a regression.
No.
Old print setup dialog supported "mm" in Firefox83 on Windows10 japanese locale/languages.
This is definitely regression from New Tab modal Print Preview.
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 6•3 years ago
|
||
Comment 8•3 years ago
|
||
Can we get an update on this?
Comment 9•3 years ago
|
||
Another SUMO complaint: https://support.mozilla.org/en-US/questions/1328249
Updated•3 years ago
|
Assignee | ||
Comment 10•3 years ago
|
||
I have a WIP patch that addresses this. It is on the back-burner for now as I have other higher-priority tasks I'm afraid. The patch exposes an existing bug we have where its possible to get an undefined paper object when we try to assemble the preset margin values. I don't think its too much work to resolve those issues and get this back in for review, and I hope to get back to it soon.
Updated•3 years ago
|
Comment 11•3 years ago
|
||
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3db292778c46 Use the paperSizeUnit to display and handle mm/inch custom margin values. r=emalysz,fluent-reviewers,flod
Comment 12•3 years ago
|
||
bugherder |
Comment 13•3 years ago
|
||
I apologise for not being sufficiently technical to understand the code in this update, but does it mean that a fix has been found and implemented? I have Firefox 86.0.1 (updated 15 minutes ago) and I am still unable to set custom print margins in mm despite print_paper_size_unit being set to 1.
Comment 14•3 years ago
|
||
I have Firefox 86.0.1 (updated 15 minutes ago) and I am still unable to set custom print margins in mm despite print_paper_size_unit being set to 1.
The change landed in the development branch of Firefox two hours ago. This means that you can see this in the next build of Firefox Nightly or in Firefox Beta once Firefox 88 hits the Beta channel or in the stable release of Firefox 88 once released ("Target Milestone: --- → 88 Branch").
Comment 15•3 years ago
|
||
Thank you. I will check this again once I have received Firefox 88 and, if it helps, report back.
May I say that I am both impressed with and appreciative of the excellent communications from the Bugzilla team to keep me informed of progress with this issue.
Comment 16•3 years ago
|
||
Hello. I'm at 88, no option to change it on the modal print, is there any option that I need to turn on first as on preferences I don't see one?
Comment 17•3 years ago
|
||
Hello, print_paper_size_unit should be shown on the preferences, not average user know about it. Please consider it. Thank you.
Comment 18•3 years ago
|
||
Having updated to FF88 I can confirm that print_paper_size_unit = 1 does indeed allow custom print margins to be set in mm. Thank you for the fix.
Mr. Limanto does make a good point. It would be a very user-friendly enhancement if changes to paper size, e.g. A4 to 8x10in., automatically changed the custom print margins between mm and inches. Not everyone is knowledgeable or brave enough to venture into about:config to make the print_paper_size_unit change manually.
Comment 19•2 years ago
|
||
Firefox 104. Print margins still disrespect local standards. Shows inches in Europe.
Comment 20•2 years ago
|
||
When saving to PDF*
Description
•