about:addons Focus ring remains on bottom buttons
Categories
(Firefox :: Settings UI, defect)
Tracking
()
People
(Reporter: cfogel, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Affected versions
- 85.0a1 (2020-12-09), 84.0;
Affected platforms
- macOS 10.15, Windows 10, Ubuntu 20;
Steps to reproduce
- Launch Firefox, access about:addons
- Click on the Nightly Preferences button;
- Click on the Extensions and themes button;
Expected result
- no glitches occur;
Actual result
- Nightly Preferences and Add-ons Support buttons have focus rings (right side is cut-off as well making it stand out even more);
Regression range
- First bad: 2020-05-16;
- Last good: 2020-05-15;
- Pushlog: URL
- Potential regressor: 1638127
Additional notes
- attached recording with the issue;
- S4 as suggested severity.
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 1•3 years ago
|
||
Adjusted component based on regressor.
@Emilio, mind confirming if it's accurate? Thanks!
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 2•3 years ago
|
||
This looks like a progression, actually, based on the intended behavior for non-e10s.
We could have a "don't show rings" flags and pass it around or something, but honestly I think the new behavior is just superior... We might want the outlines to not be cropped though, but that's a CSS issue with the sidebar.
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09b1ea766159 Don't crop outlines of sidebar-footer-links. r=Gijs
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
|
||
Comment 6•3 years ago
|
||
I managed to re produce the issue using an older version of Nightly from 2020-12-10.
I retested everything using Nightly 86.0a1 and Firefox 85.0b2 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. I've noticed two things:
- The buttons still have the focus rings. Is that expected?
- On macOS 10.13, the focus ring appears only around "Firefox Preferences" button, but not around "Extensions & Themes". Which is a inconsistent behaviour compared to the other two OS's ( Windows and Ubuntu, where the both buttons have focus rings).
|
|
Assignee | |
Comment 7•3 years ago
|
||
(In reply to Oana Botisan, Desktop Release QA from comment #6)
- The buttons still have the focus rings. Is that expected?
Yes
- On macOS 10.13, the focus ring appears only around "Firefox Preferences" button, but not around "Extensions & Themes". Which is a inconsistent behaviour compared to the other two OS's ( Windows and Ubuntu, where the both buttons have focus rings).
One is a <button> and the other a <a>, so yeah, per OSX platform convention the <button> shouldn't get focus, see:
data:text/html,<style>:focus { outline: 1px solid blue; }</style><a href="" tabindex=0>foo</a><button>foo</button>
|
|
||
Comment 8•3 years ago
|
||
Thank you, Emilio, for the fast response.
Considering the comment 6 and comment 7, I will mark this bug as verified fixed.
Description
•