Hide <menuitem> behind a flag
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: saschanaz, Assigned: saschanaz)
References
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Not sure how to conditionally turn off menu[type="context"] style rule. Emilio, could you help?
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 3•3 years ago
|
||
@supports -moz-bool-pref("....") can be used in UA sheets. Requires a restart but that's probably ok for your purposes.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Cool, thanks!
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ea7d760b4a8 Hide <menuitem> behind a flag r=smaug
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5fce6a4b5b9 Move the pref at the begining of the manifest. a=trivial-fix CLOSED TREE
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da913c816303 Backed out 2 changesets for xpcshell and mochitest plain failures. CLOSED TREE
|
||
Comment 8•3 years ago
|
||
Backed out for xpcshell and mochitest plain failures.
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&revision=8ea7d760b4a83c6646989bd4ae81a01e8c3472de&searchStr=xpc&selectedTaskRun=Ky_gbIWnTm-ZMk9pnmUMVA.0
Failure logs: https://treeherder.mozilla.org/logviewer?job_id=323809353&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=323808343&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/da913c8163038ac145204d1af35910e84c9cd2d1
|
|
Assignee | |
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 9•3 years ago
|
||
Depends on D98684
|
||
Comment 10•3 years ago
|
||
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6cc287d1291e Part 1: Hide <menuitem> behind a flag r=smaug https://hg.mozilla.org/integration/autoland/rev/4ff8babaa774 Part 2: Replace the use of HTML menuitem in a LoginManagerContextMenu test r=tgiles
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 11•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6cc287d1291e
https://hg.mozilla.org/mozilla-central/rev/4ff8babaa774
|
|
||
Comment 12•3 years ago
|
||
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/af42644bed94 Port bug 1680596 - Hide <menuitem> behind a flag. rs=bustage-fix
|
||
Comment 13•3 years ago
|
||
BCD and update to release notes are done pending merge.
|
||
Comment 14•3 years ago
|
||
What should I as a web and/or extension developer expect as a result of this?
Should I expect <menu type="context"> (and <menuitem> inside it) behavior (for registering items in the general right click/context menu) to change? Should I expect visible <menu> and <menuitem> behavior to change? Should I expect JS DOM access to these elements to change? Something else?
Should I expect these changes to already be in effect for Nightly?
|
|
Assignee | |
Comment 15•3 years ago
|
||
Yes, <menu type="context"> is not a thing anymore and it works as a typical <menu> (which again is roughly an equivalent of <ul>). <menuitem> is now gone and thus gives no effect anymore.
The changes are in Nightly and also in Beta.
|
|
||
Comment 16•3 years ago
|
||
Repro case: https://github.com/greasemonkey/greasemonkey/issues/3101#issuecomment-766438363
I'm finding that using <menuitem> in an HTML doc is now actively broken (in Nightly). Specifically: when JS sets the disabled property, no matching DOM attribute is created.
|
|
Assignee | |
Comment 17•3 years ago
|
||
That's expected because we are dropping <menuitem>. It's also dropped from the HTML spec because of no implementer interest, so extensions shouldn't rely on it.
See also: https://groups.google.com/g/mozilla.dev.platform/c/tc11BCenm2c
Description
•