Import bookmarks button is missing when starting with Firefox with browser.toolbars.bookmarks.2h2020 set to false and manually changing it to true
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
People
(Reporter: dcicas, Assigned: Gijs)
References
Details
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- Fx 84.0b7
Affected platforms
- Win 10 x64
Ubuntu 18.04 x64
macOS 11.0
Steps to reproduce
- Start Firefox with a fresh profile.
- Reach about:config.
- Set browser.toolbars.bookmarks.2h2020 to true.
- Restart the browser.
- Open a new tab.
Expected result
- The bookmark toolbar is displayed and the import button is present.
Actual result
- The bookmark toolbar is displayed but the import button is not present if the pref is set to true after first opening Firefox.
Suggested Severity
- S1 because this is an important part of the feature.
Regression range
Is not a regression.
Additional notes
When using a user.js to start with the pref on true then the issue does not reproduce.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
This allows the pref to cause us to add the button later during the uptime of the first run. Note that this
would still require us to apply the experimental pref during the first run - it won't work if the experiment
only applies on the next run - the only way to do that would be to save even more state in a pref or similar,
and that didn't seem worth it.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Comment on attachment 9191041 [details]
Bug 1680274 - enabling the experiment pref during first startup should show the import button in the toolbar, r?jaws
Beta/Release Uplift Approval Request
- User impact if declined: Running an experiment with the 2020 bookmarks pref has unpredictable results wrt the import button
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment #0
- List of other uplifts needed: n/a
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Reasonably straightforward change with automated test coverage
- String changes made/needed: Nope
|
|
Assignee | |
Updated•4 years ago
|
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/397a9ae6efd4 enabling the experiment pref during first startup should show the import button in the toolbar, r=jaws
|
||
Comment 4•4 years ago
|
||
Comment on attachment 9191041 [details]
Bug 1680274 - enabling the experiment pref during first startup should show the import button in the toolbar, r?jaws
Approved for 84.0b8. Thanks for including a test.
|
|
||
Comment 5•4 years ago
|
||
| bugherder uplift | ||
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
Reporter | |
Comment 7•4 years ago
|
||
Hello,
This issue is verified on 84.0b8 and 85.0a1 (Build ID: 20201203215210) on Win 10, Win 7, ubuntu 20 and macOS 11.00.
Description
•