Enable Pre-XUL skeleton UI on Nightly
Categories
(Firefox :: General, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: alexical, Assigned: alexical)
References
(Blocks 1 open bug)
Details
(Whiteboard: [skeleton-ui-experiment-blocker])
Attachments
(8 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Comment 1•3 years ago
|
||
Previously, we implemented arg checking with marionette
just carrying a free
pass, so we could let the arguments which typically come when running tests.
However, some marionette tests do like to play with arguments which we do not
want to get a free pass, such as -safe-mode. These changes allow just the
-profile argument through, as that is necessary for running tests.
Assignee | ||
Comment 2•3 years ago
|
||
Some env vars have effects similar to command line arguments which present
problems for the skeleton UI, and we want to treat these env vars similarly.
Depends on D98474
Assignee | ||
Comment 3•3 years ago
|
||
This prevents an assertion from tripping below.
Depends on D98475
Assignee | ||
Comment 4•3 years ago
|
||
Having the window present earlier changes the ordering of these events, such
that it doesn't come through at the time that the browser_startup test needs it
to. I think this event should be correct anyway, given that we already painted
the skeleton UI?
Depends on D98476
Assignee | ||
Comment 5•3 years ago
|
||
This was causing us to have slightly wrong focusring behavior, leading to wpt
failures in focus-visible-005.html.
Depends on D98478
Assignee | ||
Comment 6•3 years ago
|
||
Depends on D98479
Assignee | ||
Comment 7•3 years ago
|
||
Depends on D98479
Assignee | ||
Comment 8•3 years ago
|
||
I don't have a crystal clear story of why these timings are different with the
skeleton UI enabled. However, it's not remarkably surprising that it changes the
order of some events during startup which come from the core Windows event loop.
I don't think it's worth diving incredibly deep to understand this - looking at
the profile we still only see one of each of these events.
Depends on D99110
Assignee | ||
Updated•3 years ago
|
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9b9f97caa6c Improve skeleton UI arg checking for marionette r=Gijs https://hg.mozilla.org/integration/autoland/rev/268d2aac128e Check for problematic env vars for skeleton UI r=Gijs https://hg.mozilla.org/integration/autoland/rev/183d89827d4b Don't try to draw rects with 0 width or height r=emalysz https://hg.mozilla.org/integration/autoland/rev/a253801a3155 Change first paint notification event when skele UI enabled r=florian https://hg.mozilla.org/integration/autoland/rev/403d7441eb0c Ensure UI state initialized for skeleton UI r=mhowell https://hg.mozilla.org/integration/autoland/rev/8eb4ebbd13d0 Ensure we properly clamp values to draw region r=mstange https://hg.mozilla.org/integration/autoland/rev/4b885b40c787 Relax startup IPC test for skeleton UI due to paint timings r=florian
Comment 10•3 years ago
|
||
Backout by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4dc1badd9c7 Backed out 7 changesets for causing osx mochitest timeouts.
Comment 11•3 years ago
|
||
Backed out 7 changesets (Bug 1680258) for causing osx mochitest timeouts.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a4dc1badd9c732408e6c7d4204524b6afa92c0ed
Failure logs:
- wpt: https://treeherder.mozilla.org/logviewer?job_id=324079445&repo=autoland&lineNumber=1002
- webgl: https://treeherder.mozilla.org/logviewer?job_id=324079348&repo=autoland&lineNumber=1678
- bc: https://treeherder.mozilla.org/logviewer?job_id=324075233&repo=autoland&lineNumber=1448
- jreftest: https://treeherder.mozilla.org/logviewer?job_id=324078424&repo=autoland&lineNumber=1609
Assignee | ||
Comment 12•3 years ago
|
||
I'm very confused by this? None of this is even compiled on OSX.
Comment 13•3 years ago
|
||
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2ec458a63aa Improve skeleton UI arg checking for marionette r=Gijs https://hg.mozilla.org/integration/autoland/rev/b937607a2086 Check for problematic env vars for skeleton UI r=Gijs https://hg.mozilla.org/integration/autoland/rev/dc51252ef65c Don't try to draw rects with 0 width or height r=emalysz https://hg.mozilla.org/integration/autoland/rev/4b8533805da7 Change first paint notification event when skele UI enabled r=florian https://hg.mozilla.org/integration/autoland/rev/3c29ebb65840 Ensure UI state initialized for skeleton UI r=mhowell https://hg.mozilla.org/integration/autoland/rev/00e863166a86 Ensure we properly clamp values to draw region r=mstange https://hg.mozilla.org/integration/autoland/rev/4f79a1f41723 Relax startup IPC test for skeleton UI due to paint timings r=florian
Comment 14•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b2ec458a63aa
https://hg.mozilla.org/mozilla-central/rev/b937607a2086
https://hg.mozilla.org/mozilla-central/rev/dc51252ef65c
https://hg.mozilla.org/mozilla-central/rev/4b8533805da7
https://hg.mozilla.org/mozilla-central/rev/3c29ebb65840
https://hg.mozilla.org/mozilla-central/rev/00e863166a86
https://hg.mozilla.org/mozilla-central/rev/4f79a1f41723
Assignee | ||
Updated•3 years ago
|
Comment 15•3 years ago
|
||
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5bcb9f8eab9 Enable skeleton UI on nightly r=mhowell
Comment 16•3 years ago
|
||
bugherder |
Description
•